Fix reactivity overload (frozen UI when displaying lots of files while developing in web-app-files) #5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
💥 Acceptance tests webUIOCISRename failed. The build is cancelled... |
💥 Acceptance tests webUIOCISFiles2 failed. The build is cancelled... |
💥 Acceptance tests webUIOCISBasic failed. The build is cancelled... |
💥 Acceptance tests webUIOCISSharingBasic failed. The build is cancelled... |
fschade
force-pushed
the
fix-file-reactivity-overload
branch
from
813cfd3 to
06e196d
Compare
💥 Acceptance tests OCISSharingInternalGroups failed. The build is cancelled... |
💥 Acceptance tests webUIOCISFiles2 failed. The build is cancelled... |
💥 Acceptance tests webUIOCISSharingBasic failed. The build is cancelled... |
💥 Acceptance tests webUIOCISFiles1 failed. The build is cancelled... |
💥 Acceptance tests OCISSharingInternalUsers2 failed. The build is cancelled... |
💥 Acceptance tests XGAPortrait1 failed. The build is cancelled... |
💥 Acceptance tests XGAPortrait2 failed. The build is cancelled... |
💥 Acceptance tests SharingInternalGroups failed. The build is cancelled... |
💥 Acceptance tests OCISSharingInternalUsers2 failed. The build is cancelled... |
💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16584/
webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-114.pngwebUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-104.png💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. The build is cancelled... |
💥 Acceptance tests IntegrationApp1 failed. The build is cancelled... |
💥 Acceptance tests webUIFiles2 failed. The build is cancelled... |
💥 Acceptance tests webUIOCISRename failed. The build is cancelled... |
💥 Acceptance tests SharingPermissionToRoot failed. The build is cancelled... |
💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16589/
webUISharingPublicManagement-publicLinkIndicator-feature-12.pngwebUISharingPublicManagement-publicLinkIndicator-feature-27.pngwebUISharingPublicManagement-publicLinkIndicator-feature-37.png💥 Acceptance tests SharingPublicManagement failed. The build is cancelled... |
check if resource has a usershare, if not skip LOAD_INDICATORS use UPDATE_RESOURCE_KEY wherever posible use getIndicators to obtain if a resource has an indicator
fschade
force-pushed
the
fix-file-reactivity-overload
branch
from
8ef3273 to
1770346
Compare
kulmann
reviewed
Jun 21, 2021
pascalwengerter
changed the title
pascalwengerter
changed the title
💥 Acceptance tests SharingInternalUsersRoot2 failed. The build is cancelled... |
💥 Acceptance tests SharingPublicBasic failed. The build is cancelled... |
💥 Acceptance tests OCISResharing1 failed. The build is cancelled... |
💥 Acceptance tests SharingFolderAdvancedPermissionMU failed. The build is cancelled... |
💥 Acceptance tests IntegrationApp1 failed. The build is cancelled... |
💥 Acceptance tests SharingFolderPermissions failed. The build is cancelled... |
💥 Acceptance tests webUIFiles1 failed. The build is cancelled... |
💥 Acceptance tests OCISSharingPublic failed. The build is cancelled... |
💥 Acceptance tests OCISSharingInternalGroups failed. The build is cancelled... |
|
SonarCloud Quality Gate failed. |
kulmann
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
when a lot of files are displayed in files table, the web ui lacks.
This happens because we update a reference to a files object, even if we clone the collection by using the spread operator
[...this.object]child objects are still passed by reference not value.The update event then gets triggered multiple times even if it's not needed.... resulting with a frozen ui.
This only happens in dev mode because of strict mode and outside mutation:
web/packages/web-runtime/src/store/index.js
Line 28 in 39cdc09
we also hammer vuex by adding the full resource on every mutation, this pr also adds the ability to update certain resource keys only.
Related Issue
fastlaneitemMotivation and Context
have a snappy ui ;)
How Has This Been Tested?
Types of changes
Checklist:
not now, will be done in the process of typescript migration