Add mode prop for opening file editors #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
force-pushed
the
file-editor-handler-tweaks
branch
from
c96b3f9 to
f02ff7c
Compare
💥 Acceptance tests OCIS-Trashbin-Upload-Move-Journey failed. The build is cancelled... |
💥 Acceptance tests Trashbin failed. The build is cancelled... |
|
Kudos, SonarCloud Quality Gate passed! |
LukasHirt
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added a parameter called
modeto the different ways of opening a file editor. The mode can beeditorcreateand reflects whether the file editor was opened in an editing mode or in a creation mode.Resisted the urge to refactor anything, as the extension loading and handling will get an urgently needed overhaul soon anyway.
Related Issue
Motivation and Context
Enable extension developers to react differently to edit and create actions.
Types of changes
Checklist: