-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] feat: add pagination #5224
Conversation
This comment has been minimized.
This comment has been minimized.
0df432a
to
fd6923c
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
cc54331
to
ab280b8
Compare
Something for separate PR - merge unit and integration tests coverage to get the real coverage result |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm, I'm wondering if we want to go with the left- and right-alignment of the pagination and files/folder count sections?
I'd vote in favor of having them centered for a more organized look. Also, when no pagination is shown it looks off having the file/folder count aligned to the right with vast emptiness left & center
Also, from an a11y standpoint we should also maybe give context on whether the displayed file/folder count&size is defined by the current page or all files in the accommodating folder? |
2d266d6
to
deeacf4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16448/
webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-136.pngwebUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-124.png |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome progress with the integration tests! Very cool pagination. LGTM 🥳 🚀 😍
💥 Acceptance tests SharingInternalGroupsSharingIndicator failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingInternalGroupsSharingIndicator-shareWithGroups-feature-136.pngwebUISharingInternalGroupsToRootSharingIndicator-shareWithGroups-feature-124.png |
💥 Acceptance tests SharingInternalUsersBlacklisted failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingInternalUsersBlacklisted-shareWithUsers-feature-26.pngwebUISharingInternalUsersBlacklisted-shareWithUsers-feature-44.pngwebUISharingInternalUsersBlacklisted-shareWithUsers-feature-62.pngwebUISharingInternalUsersBlacklisted-shareWithUsers-feature-80.pngwebUISharingInternalUsersBlacklisted-shareWithUsers-feature-92.png |
💥 Acceptance tests SharingInternalUsersSharingIndicator failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingInternalUsersSharingIndicator-shareWithUsers-feature-17.pngwebUISharingInternalUsersSharingIndicator-shareWithUsers-feature-58.pngwebUISharingInternalUsersToRootSharingIndicator-shareWithUsers-feature-118.png |
💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingAcceptSharesToRoot-acceptShares-feature-31.png |
💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingPublicManagement-publicLinkIndicator-feature-110.pngwebUISharingPublicManagement-shareByPublicLink-feature-102.pngwebUISharingPublicManagement-shareByPublicLink-feature-120.pngwebUISharingPublicManagement-shareByPublicLink-feature-131.pngwebUISharingPublicManagement-shareByPublicLink-feature-146.pngwebUISharingPublicManagement-shareByPublicLink-feature-164.pngwebUISharingPublicManagement-shareByPublicLink-feature-90.png |
💥 Acceptance tests Move-Upload failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUIUpload-upload-feature-89.png |
💥 Acceptance tests SharingFilePermission failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers-feature-60.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers-feature-61.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers-feature-62.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers-feature-63.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers-feature-64.pngwebUISharingFilePermissionMultipleUsers-shareFileWithMultipleUsers-feature-65.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup-feature-61.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup-feature-62.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup-feature-63.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup-feature-64.pngwebUISharingFilePermissionsGroups-sharePermissionsGroup-feature-65.png |
💥 Acceptance tests SharingFolderAdvancedPermissionMU failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-60.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-61.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-62.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-63.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-64.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-65.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-66.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-67.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-68.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-69.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-70.pngwebUISharingFolderAdvancedPermissionMultipleUsers-sharedFolderWithMultipleUsersAdvancedPermissions-feature-71.png |
💥 Acceptance tests SharingFolderPermissions failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-61.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-62.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-63.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-64.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-65.pngwebUISharingFolderPermissionMultipleUsers-shareFolderWithMultipleUsers-feature-66.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-61.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-62.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-63.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-64.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-65.pngwebUISharingFolderPermissionsGroups-sharePermissionsGroup-feature-66.png |
💥 Acceptance tests SharingFolderAdvPermissionsGrp failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-61.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-62.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-63.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-64.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-65.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-66.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-67.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-68.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-69.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-70.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-71.pngwebUISharingFolderAdvancedPermissionsGroups-shareAdvancePermissionsGroup-feature-72.png |
💥 Acceptance tests IntegrationApp1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUIPrivateLinks-accessingPrivateLinks-feature-17.pngwebUIPrivateLinks-accessingPrivateLinks-feature-9.pngwebUIRestrictSharing-disableSharing-feature-16.pngwebUIRestrictSharing-restrictReSharing-feature-23.pngwebUIRestrictSharing-restrictReSharing-feature-42.pngwebUIRestrictSharing-restrictSharing-feature-31.pngwebUIRestrictSharing-restrictSharing-feature-40.pngwebUIRestrictSharing-restrictSharing-feature-56.png |
💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUIFilesDetails-fileDetails-feature-116.pngwebUIFilesDetails-fileDetails-feature-14.pngwebUIFilesDetails-fileDetails-feature-163.pngwebUIFilesDetails-fileDetails-feature-172.pngwebUIFilesDetails-fileDetails-feature-25.pngwebUIFilesDetails-fileDetails-feature-38.pngwebUIFilesDetails-fileDetails-feature-51.pngwebUIFilesDetails-fileDetails-feature-66.pngwebUIFilesDetails-fileDetails-feature-82.pngwebUIFilesDetails-fileDetails-feature-99.png |
💥 Acceptance tests IntegrationApp2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingAutocompletion-shareAutocompletion-feature-32.pngwebUISharingAutocompletion-shareAutocompletion-feature-44.pngwebUISharingInternalUsers-shareWithUsers-feature-57.pngwebUISharingInternalUsers-shareWithUsers-feature-58.pngwebUISharingInternalUsers-shareWithUsers-feature-59.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-52.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-53.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-54.pngwebUISharingPublicBasic-publicLinkCreate-feature-11.pngwebUISharingPublicBasic-publicLinkCreate-feature-28.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-33.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-34.pngwebUISharingPublicDifferentRoles-shareByPublicLinkDifferentRoles-feature-35.pngwebUIUpload-upload-feature-89.png |
💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUILogin-adminBlocksUser-feature-20.pngwebUIPreview-imageMediaViewer-feature-140.pngwebUIPreview-imageMediaViewer-feature-158.pngwebUIPreview-imageMediaViewer-feature-83.pngwebUIPreview-imageMediaViewer-feature-90.pngwebUIPrivateLinks-accessingPrivateLinks-feature-17.pngwebUIPrivateLinks-accessingPrivateLinks-feature-25.pngwebUIPrivateLinks-accessingPrivateLinks-feature-9.png |
💥 Acceptance tests SharingInternalUsersRoot2 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-100.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-109.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-31.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-32.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-33.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-34.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-37.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-44.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-54.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-74.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-75.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-78.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-86.pngwebUISharingInternalUsersToRootCollaborator-shareWithUsers-feature-93.pngwebUISharingInternalUsersToRootPreviews-shareWithUsers-feature-11.pngwebUISharingInternalUsersToRootPreviews-shareWithUsers-feature-25.pngwebUISharingInternalUsersToRootPreviews-shareWithUsers-feature-40.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-88.pngwebUISharingInternalUsersToRootShareWithPage-shareWithUsers-feature-96.png |
💥 Acceptance tests SharingInternalUsersRoot1 failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/16452/
webUISharingInternalUsersToRoot-shareWithUsers-feature-103.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-129.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-142.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-161.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-183.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-197.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-212.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-255.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-256.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-257.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-275.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-52.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-53.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-54.pngwebUISharingInternalUsersToRoot-shareWithUsers-feature-74.pngwebUISharingInternalUsersToRootBlacklisted-shareWithUsers-feature-25.pngwebUISharingInternalUsersToRootBlacklisted-shareWithUsers-feature-41.pngwebUISharingInternalUsersToRootBlacklisted-shareWithUsers-feature-55.pngwebUISharingInternalUsersToRootBlacklisted-shareWithUsers-feature-69.pngwebUISharingInternalUsersToRootBlacklisted-shareWithUsers-feature-81.png |
be9f3ea
to
e77e40b
Compare
SonarCloud Quality Gate failed. |
Changes
page
param to routes with files lists**/unit/
foldersIntegration tests
Screenshot
Todo