Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change appearance of the share action buttons #5053

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Change appearance of the share action buttons #5053

merged 1 commit into from
Apr 30, 2021

Conversation

JammingBen
Copy link
Contributor

Description

Changed the appearance of the "accept/decline share" buttons in the "Shared With Me" file list so they actually look like buttons.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen added Status:Needs-Review Needs review from a maintainer Topic:Accessibility labels Apr 30, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests MarkdownEditor failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072431-417.png
20210430-072554-909.png
20210430-072624-285.png
20210430-072653-089.png
20210430-072722-922.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072728-779.png
20210430-072802-258.png
20210430-072836-370.png
20210430-072910-019.png
20210430-072943-916.png
20210430-073016-249.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroups failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072714-513.png
20210430-072746-453.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicDifferentRoles failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072728-800.png
20210430-072755-591.png
20210430-072823-626.png
20210430-072850-807.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsersRoot2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072856-714.png
20210430-072946-074.png
20210430-073231-117.png
20210430-073301-662.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicExpire failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072725-095.png
20210430-072758-574.png
20210430-072831-974.png
20210430-072904-458.png
20210430-073051-799.png
20210430-073126-033.png
20210430-073201-310.png
20210430-073237-062.png
20210430-073330-112.png
20210430-073404-247.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinFilesFolders failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-073020-451.png
20210430-073052-365.png
20210430-073123-865.png
20210430-073155-054.png
20210430-073226-674.png
20210430-073258-582.png
20210430-073329-120.png
20210430-073359-691.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicManagement failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072923-705.png
20210430-073019-561.png
20210430-073126-668.png
20210430-073159-177.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingInternalGroupsRoot failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072753-674.png
20210430-072840-445.png
20210430-072930-069.png
20210430-073018-947.png
20210430-073101-021.png
20210430-073142-951.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsersRoot1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072749-912.png
20210430-072826-771.png
20210430-072915-614.png
20210430-073003-492.png
20210430-073045-541.png
20210430-073127-148.png
20210430-073618-677.png
20210430-073648-439.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests TrashbinRestore failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-073037-506.png
20210430-073108-255.png
20210430-073138-271.png
20210430-073208-118.png
20210430-073312-660.png
20210430-073344-126.png
20210430-073414-639.png
20210430-073444-951.png
20210430-073516-605.png
20210430-073547-508.png
20210430-073618-238.png
20210430-073648-730.png
20210430-073724-807.png
20210430-073801-875.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072954-056.png
20210430-073024-898.png
20210430-073207-485.png
20210430-073240-602.png
20210430-073314-523.png
20210430-073347-400.png
20210430-073554-619.png
20210430-073626-666.png
20210430-073732-051.png
20210430-073804-981.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIDelete failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072522-417.png
20210430-072556-761.png
20210430-072628-536.png
20210430-072701-032.png
20210430-072733-446.png
20210430-072805-375.png
20210430-072836-992.png
20210430-072908-194.png
20210430-072939-110.png
20210430-073010-036.png
20210430-073100-221.png
20210430-073134-998.png
20210430-073206-132.png
20210430-073237-431.png
20210430-073310-063.png
20210430-073342-493.png
20210430-073414-395.png
20210430-073446-494.png
20210430-073520-425.png
20210430-073554-621.png
20210430-073628-389.png
20210430-073702-351.png
20210430-073753-341.png
20210430-073824-705.png
20210430-073856-258.png
20210430-073927-590.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Favorites failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072756-596.png
20210430-072828-274.png
20210430-072859-527.png
20210430-072930-490.png
20210430-073055-711.png
20210430-073127-365.png
20210430-073159-524.png
20210430-073231-790.png
20210430-073303-013.png
20210430-073334-523.png
20210430-073406-606.png
20210430-073439-166.png
20210430-073512-126.png
20210430-073544-070.png
20210430-073617-648.png
20210430-073650-791.png
20210430-073723-925.png
20210430-073756-769.png
20210430-073845-506.png
20210430-073918-496.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072811-096.png
20210430-072850-849.png
20210430-072926-201.png
20210430-073001-110.png
20210430-073050-369.png
20210430-073125-097.png
20210430-073200-624.png
20210430-073235-620.png
20210430-073307-943.png
20210430-073339-493.png
20210430-073413-603.png
20210430-073447-186.png
20210430-073518-669.png
20210430-073550-066.png
20210430-073754-835.png
20210430-073828-902.png
20210430-073859-633.png
20210430-073929-748.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUISharingInternalUsers failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-073014-466.png
20210430-073103-744.png
20210430-073136-284.png
20210430-073208-146.png
20210430-073732-575.png
20210430-073805-983.png
20210430-074259-267.png
20210430-074333-452.png
20210430-074649-108.png
20210430-074741-084.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072750-702.png
20210430-072821-437.png
20210430-072853-629.png
20210430-072924-901.png
20210430-072955-648.png
20210430-073026-122.png
20210430-073113-020.png
20210430-073144-362.png
20210430-073215-459.png
20210430-073246-690.png
20210430-073318-702.png
20210430-073350-592.png
20210430-073419-187.png
20210430-073446-251.png
20210430-073517-715.png
20210430-073549-142.png
20210430-073621-286.png
20210430-073653-328.png
20210430-073746-961.png
20210430-073825-604.png
20210430-073858-669.png
20210430-073930-456.png
20210430-074002-260.png
20210430-074034-902.png
20210430-074106-596.png
20210430-074138-990.png
20210430-074225-702.png
20210430-074257-109.png
20210430-074328-844.png
20210430-074400-241.png
20210430-074431-902.png
20210430-074503-509.png
20210430-074535-861.png
20210430-074606-728.png
20210430-074637-627.png
20210430-074708-076.png
20210430-074738-817.png
20210430-074807-793.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles1 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072841-575.png
20210430-072911-707.png
20210430-072942-402.png
20210430-073012-883.png
20210430-073331-439.png
20210430-073403-205.png
20210430-073434-865.png
20210430-073506-943.png
20210430-073555-143.png
20210430-073626-214.png
20210430-073657-837.png
20210430-073729-549.png
20210430-073801-608.png
20210430-073833-595.png
20210430-073905-418.png
20210430-073937-389.png
20210430-074005-957.png
20210430-074033-939.png
20210430-074105-396.png
20210430-074137-923.png
20210430-074210-225.png
20210430-074242-230.png
20210430-074312-429.png
20210430-074343-213.png
20210430-074414-067.png
20210430-074444-790.png
20210430-074516-490.png
20210430-074548-272.png
20210430-074637-329.png
20210430-074710-699.png
20210430-074744-090.png
20210430-074817-153.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072843-273.png
20210430-072911-530.png
20210430-073031-425.png
20210430-073100-240.png
20210430-073128-699.png
20210430-073158-417.png
20210430-073227-733.png
20210430-073256-450.png
20210430-073325-861.png
20210430-073355-812.png
20210430-073423-225.png
20210430-073449-087.png
20210430-073515-417.png
20210430-073541-099.png
20210430-073610-137.png
20210430-073640-526.png
20210430-073710-586.png
20210430-073740-615.png
20210430-073810-442.png
20210430-073840-288.png
20210430-073910-174.png
20210430-073940-811.png
20210430-074020-061.png
20210430-074050-185.png
20210430-074119-948.png
20210430-074149-774.png
20210430-074252-886.png
20210430-074323-694.png
20210430-074353-951.png
20210430-074424-234.png
20210430-074454-989.png
20210430-074525-723.png
20210430-074555-234.png
20210430-074625-732.png
20210430-074726-989.png
20210430-074759-310.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublicBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072722-802.png
20210430-072755-438.png
20210430-072829-509.png
20210430-072903-203.png
20210430-072936-985.png
20210430-073010-842.png
20210430-073212-988.png
20210430-073246-133.png
20210430-073319-228.png
20210430-073352-453.png
20210430-073425-096.png
20210430-073458-424.png
20210430-073531-402.png
20210430-073604-422.png
20210430-073637-705.png
20210430-073711-098.png
20210430-073744-870.png
20210430-073818-157.png
20210430-073851-432.png
20210430-073924-675.png
20210430-073957-701.png
20210430-074031-280.png
20210430-074104-296.png
20210430-074137-589.png
20210430-074210-907.png
20210430-074244-155.png
20210430-074317-184.png
20210430-074350-247.png
20210430-074423-194.png
20210430-074456-508.png
20210430-074529-401.png
20210430-074602-212.png
20210430-074635-320.png
20210430-074705-923.png
20210430-074737-996.png
20210430-074810-560.png
20210430-074844-331.png
20210430-074917-912.png
20210430-074950-665.png
20210430-075023-662.png
20210430-075056-234.png
20210430-075129-359.png
20210430-075200-667.png
20210430-075231-257.png
20210430-075301-421.png
20210430-075332-469.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15230/

20210430-072552-306.png
20210430-072626-745.png
20210430-072659-580.png
20210430-072732-753.png
20210430-072805-688.png
20210430-072839-317.png
20210430-072912-877.png
20210430-072945-972.png
20210430-073019-233.png
20210430-073051-908.png
20210430-073124-751.png
20210430-073157-323.png
20210430-073229-721.png
20210430-073302-660.png
20210430-073335-831.png
20210430-073409-637.png
20210430-073442-894.png
20210430-073515-771.png
20210430-073548-672.png
20210430-073620-447.png
20210430-073653-101.png
20210430-073725-795.png
20210430-073758-587.png
20210430-073832-372.png
20210430-073905-815.png
20210430-073938-532.png
20210430-074011-209.png
20210430-074044-038.png
20210430-074116-626.png
20210430-074149-660.png
20210430-074221-867.png
20210430-074254-427.png
20210430-074327-117.png
20210430-074359-813.png
20210430-074432-851.png
20210430-074505-820.png
20210430-074537-903.png
20210430-074610-140.png
20210430-074642-877.png
20210430-074715-417.png
20210430-074748-492.png
20210430-074821-575.png
20210430-074854-784.png
20210430-074927-386.png
20210430-075000-427.png
20210430-075033-254.png
20210430-075108-000.png
20210430-075142-032.png
20210430-075220-539.png
20210430-075257-628.png
20210430-075334-201.png
20210430-075411-205.png
20210430-075446-301.png
20210430-075522-118.png
20210430-075556-286.png
20210430-075629-547.png
20210430-075700-195.png
20210430-075732-934.png
20210430-075805-745.png
20210430-075838-358.png
20210430-075910-016.png
20210430-075941-426.png
20210430-080013-597.png
20210430-080046-244.png
20210430-080118-098.png
20210430-080151-058.png
20210430-080222-874.png
20210430-080254-873.png
20210430-080326-537.png
20210430-080357-747.png
20210430-080428-946.png
20210430-080500-780.png
20210430-080532-205.png
20210430-080605-439.png
20210430-080638-069.png
20210430-080711-580.png
20210430-080744-888.png
20210430-080817-981.png
20210430-080849-713.png
20210430-080922-084.png
20210430-080955-063.png
20210430-081026-307.png
20210430-081058-559.png
20210430-081130-850.png
20210430-081203-266.png
20210430-081235-806.png
20210430-081308-205.png
20210430-081340-905.png
20210430-081412-827.png
20210430-081445-363.png
20210430-081517-882.png
20210430-081550-968.png
20210430-081623-718.png
20210430-081656-195.png
20210430-081728-870.png
20210430-081801-559.png
20210430-081834-019.png
20210430-081906-408.png
20210430-081937-403.png
20210430-082009-136.png
20210430-082041-483.png
20210430-082114-445.png

pascalwengerter
pascalwengerter approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌🏽

@JammingBen JammingBen merged commit d3ab86d into a11y-swarming Apr 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the share-buttons branch April 30, 2021 09:53
@individual-it individual-it mentioned this pull request May 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

Assignees
No one assigned
Labels
Status:Needs-Review Needs review from a maintainer Topic:Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JammingBen @ownclouders @pascalwengerter @AlexAndBear