Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a proper definition list for the account settings page #5012

Merged
merged 4 commits into from
Apr 26, 2021
Merged

Use a proper definition list for the account settings page #5012

merged 4 commits into from
Apr 26, 2021
+49 −24

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Apr 23, 2021 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@JammingBen JammingBen added Status:Needs-Review Needs review from a maintainer Topic:Accessibility labels Apr 23, 2021
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15055/

20210423-142957-514.png
20210423-143026-090.png
20210423-143055-715.png
20210423-143125-700.png
20210423-143156-069.png
20210423-143226-768.png
20210423-143318-521.png
20210423-143353-813.png
20210423-143742-488.png
20210423-143811-318.png
20210423-143841-273.png
20210423-143910-628.png
20210423-144023-258.png
20210423-144053-247.png
20210423-144131-670.png
20210423-144202-072.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIBasic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15056/

20210423-143422-244.png
20210423-143452-440.png
20210423-143520-987.png
20210423-143548-891.png
20210423-143618-648.png
20210423-143649-749.png
20210423-143742-801.png
20210423-143815-317.png
20210423-144150-363.png
20210423-144219-804.png
20210423-144249-628.png
20210423-144319-427.png
20210423-144426-099.png
20210423-144455-164.png
20210423-144535-119.png
20210423-144605-888.png

pascalwengerter
pascalwengerter requested changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go, me gusta mucho!

packages/web-runtime/src/pages/account.vue Outdated Show resolved Hide resolved
pascalwengerter
pascalwengerter approved these changes Apr 26, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 🙌🏽

@JammingBen JammingBen force-pushed the account-definition-list branch from 0b506c2 to 2f15566 Compare April 26, 2021 08:46
@kulmann kulmann changed the base branch from master to a11y-swarming April 26, 2021 08:57
@kulmann kulmann merged commit a8d1384 into a11y-swarming Apr 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the account-definition-list branch April 26, 2021 08:57
@ownclouders
Copy link
Contributor

💥 Acceptance tests Move failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/15098/

20210426-085821-894.png
20210426-090000-258.png
20210426-090032-918.png
20210426-090103-346.png
20210426-090223-415.png
20210426-090349-680.png
20210426-090403-907.png

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@fschade fschade Awaiting requested review from fschade

Assignees
No one assigned
Labels
Status:Needs-Review Needs review from a maintainer Topic:Accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JammingBen @ownclouders @kulmann @pascalwengerter