Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use real titles in location picker #5009

Merged
merged 1 commit into from
Apr 23, 2021
Merged

feat: use real titles in location picker #5009

merged 1 commit into from
Apr 23, 2021

Conversation

LukasHirt
Copy link
Collaborator

Description

We've added real page titles to the location picker. The title is consisted of the current action, target and product name.

Screenshots (if appropriate):

Screenshot 2021-04-23 at 14 16 55
Screenshot 2021-04-23 at 14 16 59

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@LukasHirt LukasHirt added the Category:Enhancement Add new functionality label Apr 23, 2021
@LukasHirt LukasHirt self-assigned this Apr 23, 2021
pascalwengerter
pascalwengerter approved these changes Apr 23, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 🚀

@LukasHirt LukasHirt merged commit fe9dc5a into master Apr 23, 2021
@LukasHirt LukasHirt deleted the feat/location-picker-title branch April 23, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@fschade fschade Awaiting requested review from fschade

Assignees

@LukasHirt LukasHirt

Labels
Category:Enhancement Add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukasHirt @pascalwengerter