Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ods to 6.0.0 #4983

Merged
merged 6 commits into from
Apr 19, 2021
Merged

Update ods to 6.0.0 #4983

merged 6 commits into from
Apr 19, 2021

Conversation

pascalwengerter
Copy link
Contributor

Description

Update ODS to v6.0.0 and adapt CSS color variables & docs to the changes

@update-docs
Copy link

update-docs bot commented Apr 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@pascalwengerter pascalwengerter requested a review from kulmann April 19, 2021 11:17
@pascalwengerter pascalwengerter force-pushed the 19042021_update_ODS_to_6.0.0 branch from 031dea9 to cf67211 Compare April 19, 2021 11:18
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14814/

20210419-113226-774.png
20210419-113300-756.png
20210419-113334-817.png
20210419-113408-295.png
20210419-113639-599.png
20210419-113713-731.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIRename failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14814/

20210419-112508-874.png
20210419-112542-790.png
20210419-112616-057.png
20210419-112649-145.png
20210419-112722-289.png
20210419-112755-427.png
20210419-112828-813.png
20210419-112902-063.png
20210419-112935-049.png
20210419-113008-261.png
20210419-113157-523.png
20210419-113230-791.png

@kulmann kulmann force-pushed the 19042021_update_ODS_to_6.0.0 branch from cf67211 to 83f9d1c Compare April 19, 2021 11:56
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was a time before we had an ocis monorepo. We had an ocis-web repo back then, which is now the web folder within the ocis monorepo. Having that in mind, it's now easier to release web. 1) release web, 2) then update web in ocis, 3) be done.

### Spacing

Changing the spacing via a custom theme is not yet supported and will be released in the future. If this is a pressing feature you'd like to use soon, please [open an issue on GitHub](https://github.com/owncloud/web/issues/new) or reach out to us about contribution options.
Use the six spacing options (`large | medium | small | xlarge | xsmall | xxlarge`) to create a more (or less) condensed version of the user interface. If you need more customization options regarding sizes, please [open an issue on GitHub](https://github.com/owncloud/web/issues/new) with a detailed description.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Use the six spacing options (`large | medium | small | xlarge | xsmall | xxlarge`) to create a more (or less) condensed version of the user interface. If you need more customization options regarding sizes, please [open an issue on GitHub](https://github.com/owncloud/web/issues/new) with a detailed description.
Use the six spacing options (`xsmall | small | medium | large | xlarge | xxlarge`) to create a more (or less) condensed version of the user interface. If you need more customization options regarding sizes, please [open an issue on GitHub](https://github.com/owncloud/web/issues/new) with a detailed description.

I'd prefer to sort the spacing options in ascending order.

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14816/

20210419-121154-238.png
20210419-121229-974.png
20210419-121305-404.png
20210419-121341-690.png

@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIFiles2 failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14817/

20210419-124927-875.png
20210419-125001-456.png
20210419-125035-465.png
20210419-125108-964.png
20210419-125320-941.png
20210419-125355-666.png

@kulmann kulmann merged commit 859908c into master Apr 19, 2021
@delete-merged-branch delete-merged-branch bot deleted the 19042021_update_ODS_to_6.0.0 branch April 19, 2021 13:59
ownclouders pushed a commit that referenced this pull request Apr 19, 2021
Merge: 47b9b4a 43f4768
Author: Benedikt Kulmann <benedikt@kulmann.biz>
Date:   Mon Apr 19 15:59:13 2021 +0200

    Merge pull request #4983 from owncloud/19042021_update_ODS_to_6.0.0

    Update ods to 6.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants