Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading shares of the current folder twice #4918

Merged
merged 4 commits into from
Apr 7, 2021
Merged

Fix loading shares of the current folder twice #4918

merged 4 commits into from
Apr 7, 2021

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Apr 6, 2021

Description

We had a bug that caused loading incoming and outgoing shares of the current folder twice (leading to two extra requests). Fixed it by cleaning up the helper for building parent paths. Added unit tests.

Related Issue

Motivation and Context

Bugfixing

How Has This Been Tested?

  • unit tests + looking at the network tab and not seeing duplicate share listing requests anymore for the current folder.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Apr 6, 2021
@kulmann kulmann self-assigned this Apr 6, 2021
@kulmann kulmann mentioned this pull request Apr 6, 2021
Closed
@ownclouders
Copy link
Contributor

💥 Acceptance tests SharingPublic failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/web/14290/

20210406-215643-945.png

pascalwengerter
pascalwengerter approved these changes Apr 7, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kulmann kulmann merged commit 37aba5c into master Apr 7, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix-building-parent-paths branch April 7, 2021 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@labkode labkode Awaiting requested review from labkode

@LukasHirt LukasHirt Awaiting requested review from LukasHirt

@fschade fschade Awaiting requested review from fschade

Assignees

@kulmann kulmann

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Duplicate requests when homeFolder is enabled
3 participants
@kulmann @ownclouders @pascalwengerter