-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use list element to display added people #4915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤘🏽
💥 Acceptance tests SharingFolderPermissionMultipleUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14281/
|
💥 Acceptance tests SharingPermissionToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14281/
|
💥 Acceptance tests SharingFolderAdvancedPermissionMU failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14281/
|
💥 Acceptance tests SharingFolderPermissionMultipleUsers failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14399/
|
💥 Acceptance tests SharingPermissionToRoot failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14399/
|
💥 Acceptance tests SharingFolderAdvancedPermissionMU failed. Please find the screenshots inside ...https://drone.owncloud.com/owncloud/web/14399/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, LGMT 👍
We've changed the HTML elements in the people accordion when adding new people. People added via people autocomplete are now displayed in a list element to use correct structure for screen readers.