Added only office extension opening into the existing window #4837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is an adaptation of the Only Office external app for OCIS which is compatible with OC10 backend without requiring any OCIS server or runtime. This simplifies the integration and avoids using a customer
handler
function to integrate Only Office.This is partly raised to demonstrate another approach for integrating OO, and could be used as a stepping stone to a deeper integration down the track to actually use the JS APIs in OO directly (for things like automated background saves and triggering behaviour via post messages between the application and the extension.
I have raised another similar PR #4836 which opens in a new window (as per existing design). If this approach continued to implement the direct JS API, I believe opening in the same window is a better approach (in terms of UX) but would warrant being able to hide the left-hand sidebar (which is possible) and also adding a top 'Back' button or other actions at the top to facilitate navigating out of the integrated document editor.
hideSideBar: true
in route to claim more screen real estate (will raise in a separate PR) but this will disappear if the user has a constrainted viewport by default anyway.Motivation and Context
It simplifies the integration point of Only Office in OCIS. This implementation still uses the OC10 OO plugin, but could be updated to not use it at all (and use direct JS integration with the OO JS API).
How Has This Been Tested?
Tested on the latest version of owncloud/web for a week, involving opening each type of document, making changes, going back into the parent app, seeing the changes then re-editing or downloading to confirm changes were applied.
Keep in mind you will have to add:
to your
config.json
to enable this app.Screenshots (if appropriate):
Types of changes
Checklist: