Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added only office extension opening into the existing window #4837

Conversation

rpocklin
Copy link
Contributor

@rpocklin rpocklin commented Mar 22, 2021

Description

This is an adaptation of the Only Office external app for OCIS which is compatible with OC10 backend without requiring any OCIS server or runtime. This simplifies the integration and avoids using a customer handler function to integrate Only Office.

This is partly raised to demonstrate another approach for integrating OO, and could be used as a stepping stone to a deeper integration down the track to actually use the JS APIs in OO directly (for things like automated background saves and triggering behaviour via post messages between the application and the extension.

I have raised another similar PR #4836 which opens in a new window (as per existing design). If this approach continued to implement the direct JS API, I believe opening in the same window is a better approach (in terms of UX) but would warrant being able to hide the left-hand sidebar (which is possible) and also adding a top 'Back' button or other actions at the top to facilitate navigating out of the integrated document editor.

  • Could also specify hideSideBar: true in route to claim more screen real estate (will raise in a separate PR) but this will disappear if the user has a constrainted viewport by default anyway.

Motivation and Context

It simplifies the integration point of Only Office in OCIS. This implementation still uses the OC10 OO plugin, but could be updated to not use it at all (and use direct JS integration with the OO JS API).

How Has This Been Tested?

Tested on the latest version of owncloud/web for a week, involving opening each type of document, making changes, going back into the parent app, seeing the changes then re-editing or downloading to confirm changes were applied.

Keep in mind you will have to add:

apps: [..., "onlyoffice"],

to your config.json to enable this app.

Screenshots (if appropriate):

image
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 22, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@rpocklin rpocklin force-pushed the feat/only-office-integration-same-window branch from 200242d to 8e73843 Compare March 23, 2021 22:04
@rpocklin rpocklin force-pushed the feat/only-office-integration-same-window branch from 8e73843 to 3485f66 Compare April 28, 2021 01:34
@rpocklin
Copy link
Contributor Author

rpocklin commented Apr 28, 2021

Rebased and updated (now that hideSearchBar has been merged into master.)

@rpocklin rpocklin force-pushed the feat/only-office-integration-same-window branch from 3485f66 to 6a9f7bd Compare April 28, 2021 02:50
@rpocklin rpocklin force-pushed the feat/only-office-integration-same-window branch from 6a9f7bd to 92f2dd5 Compare April 28, 2021 03:38
@rpocklin rpocklin mentioned this pull request Apr 29, 2021
9 tasks
@wkloucek wkloucek requested a review from kulmann April 30, 2021 05:53
@rpocklin
Copy link
Contributor Author

rpocklin commented Jun 7, 2021

Closing due to lack of feedback.

@rpocklin rpocklin closed this Jun 7, 2021
@kulmann
Copy link
Contributor

kulmann commented Jun 10, 2021

Hey, sorry for not getting back to you on this. The onlyoffice team is currently working on an ownCloud Web extension for their oc10 connector app. Happening here: https://github.com/ONLYOFFICE/onlyoffice-owncloud-web/tree/develop
I bet they'd be more than happy if you contributed there! Our web repo is just not the right place since this is not supposed to be a monorepo for all extensions we could imagine. But you're working on a hot topic here. Much appreciated, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants