Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Update expected to failure file #4792

Merged
merged 1 commit into from
Mar 8, 2021
Merged

[Tests-Only] Update expected to failure file #4792

merged 1 commit into from
Mar 8, 2021

Conversation

SwikritiT
Copy link
Contributor

Description

issues owncloud/ocis/issues/717 and owncloud/product/issues/203 are closed and the tests actually don't fail because of them so. This PR enables tests that do pass on both ocis & oc10 and gives the correct issue for tests that do not work.

Related Issue

Motivation and Context

How Has This Been Tested?

-Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@SwikritiT SwikritiT self-assigned this Mar 4, 2021
@SwikritiT SwikritiT force-pushed the updateExpectedToFailFile branch 4 times, most recently from 053c6b6 to 6aaa3b2 Compare March 5, 2021 05:01
Talank
Talank reviewed Mar 5, 2021
View reviewed changes
Copy link
Contributor

@Talank Talank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Talank Talank requested a review from individual-it March 5, 2021 07:04
individual-it
individual-it requested changes Mar 5, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title ### Reshare is not available in ocis (webUI) does not have any issue connected to it,
lets move all those issues under ### [enable re-sharing is not possible](https://github.com/owncloud/ocis/issues/1743)

individual-it
individual-it reviewed Mar 5, 2021
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash the commits and then we should be able to merge that
THX

@SwikritiT SwikritiT force-pushed the updateExpectedToFailFile branch 2 times, most recently from 44c2fa5 to 702f8a4 Compare March 5, 2021 08:06
@SwikritiT SwikritiT force-pushed the updateExpectedToFailFile branch from 702f8a4 to afd9ebf Compare March 8, 2021 16:10
@phil-davis phil-davis merged commit da869f4 into master Mar 8, 2021
@delete-merged-branch delete-merged-branch bot deleted the updateExpectedToFailFile branch March 8, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Talank Talank Talank left review comments

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it individual-it approved these changes

@swoichha swoichha Awaiting requested review from swoichha

@dpakach dpakach Awaiting requested review from dpakach

@jasson99 jasson99 Awaiting requested review from jasson99

@kiranparajuli589 kiranparajuli589 Awaiting requested review from kiranparajuli589

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@SwikritiT SwikritiT

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SwikritiT @phil-davis @individual-it @Talank