Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Adjust scenarios in sharedFolderWithMultipleUsersAdvancedPermissions #4419

Merged

Conversation

phil-davis
Copy link
Contributor

…now that issue-product-203 is fixed

Description

PR #4413 moved to an OCIS commit id where issue-product-203 is fixed (or at least improved). The scenario concerned was adjusted to the new correct behaviour. Actually the good scenario above it should now be used.

This PR put the Examples that pass on both oC10 and OCIS into a single "good behaviour" scenario outline.
Examples that still only pass on oC10 are in a 2nd scenario tagged skipOnOCIS
Examples of bad behaviour on OCIS due to issue-ocis-717 are in a 3rd scenario tagged skipOnOC10

Related Issue

#4418

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@phil-davis phil-davis added Status:Needs-Review Needs review from a maintainer QA:team labels Dec 4, 2020
@phil-davis phil-davis self-assigned this Dec 4, 2020
@phil-davis phil-davis changed the title Adjust scenarios in sharedFolderWithMultipleUsersAdvancedPermissions [tests-only] Adjust scenarios in sharedFolderWithMultipleUsersAdvancedPermissions Dec 4, 2020
@owncloud owncloud deleted a comment from update-docs bot Dec 4, 2020
@phil-davis
Copy link
Contributor Author

Note: this is the first thing that I noticed, and caused me to raise issue #4418
There is more work to do on that issue. Someone can be assigned next week.

@individual-it individual-it merged commit 4c4af98 into master Dec 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the adjust-scenario-for-issue-product-203-20201204 branch December 4, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA:team Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants