Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move actions to sidebar #4255

Merged
merged 75 commits into from
Nov 16, 2020
Merged
Show file tree
Hide file tree
Changes from 72 commits
Commits
Show all changes
75 commits
Select commit Hold shift + click to select a range
db098a9
Remove actions dropdown from files list
LukasHirt Oct 30, 2020
13c8914
Create actions accordion and move mixin logic into it
LukasHirt Oct 30, 2020
530ef86
Display sidebar also in trashbin
LukasHirt Oct 30, 2020
65338a7
Reset highlighted file after restore
LukasHirt Oct 30, 2020
cec6865
Adjust spacing
LukasHirt Oct 30, 2020
0d78214
Separate file actions into own mixins
LukasHirt Nov 2, 2020
c9ec0b8
Bring back default actions
LukasHirt Nov 2, 2020
71f7e44
Do not load preview in trashbin
LukasHirt Nov 2, 2020
d876fd9
Change color and font-weight of buttons
LukasHirt Nov 2, 2020
c99aa46
Fix lint errors
LukasHirt Nov 2, 2020
3972d4a
Adjust selector for actions
LukasHirt Nov 2, 2020
25270eb
Move versions on the last position
LukasHirt Nov 3, 2020
93a0dff
Expect actions panel isntead of versions
LukasHirt Nov 3, 2020
f575183
Fix newFileActions
LukasHirt Nov 3, 2020
dafdaed
Test if resource can be deleted in favorites list
LukasHirt Nov 3, 2020
35e7d55
Fix rename dialog error messages
LukasHirt Nov 3, 2020
3e684dd
Fix status indicators handler
LukasHirt Nov 3, 2020
8285177
Fix location picker
LukasHirt Nov 3, 2020
80c196b
Fix lint error
LukasHirt Nov 3, 2020
9f23fd2
Open actions accordion when clicking on three dots icon
LukasHirt Nov 3, 2020
0672f43
Update ODS
LukasHirt Nov 4, 2020
1ea3c7b
Adjust rename tests
LukasHirt Nov 4, 2020
deb3da2
Display path also in favorites list
LukasHirt Nov 4, 2020
12a1dad
Adjust switching tabs tests
LukasHirt Nov 4, 2020
92b6b9b
Adjust sharing tests
LukasHirt Nov 4, 2020
76591e7
Fix upload test
LukasHirt Nov 4, 2020
e53b276
Close sidebar before checking if resource is listed
LukasHirt Nov 5, 2020
9842533
Fix sharing tests
LukasHirt Nov 5, 2020
658cc1d
Pin ocis to most recent commit id in drone
kulmann Nov 6, 2020
fcdbca3
Enable basic auth in proxy for ocis tests
kulmann Nov 6, 2020
04c1bf7
Use "folder-open" icon for right sidebar
kulmann Nov 6, 2020
be4dd5b
Changelog items
kulmann Nov 6, 2020
a35112a
Add data driver config in drone
kulmann Nov 6, 2020
7b5351d
Revert "Add data driver config in drone"
kulmann Nov 6, 2020
0526a52
Revert "Enable basic auth in proxy for ocis tests"
kulmann Nov 6, 2020
1656373
Revert "Pin ocis to most recent commit id in drone"
kulmann Nov 6, 2020
68cce11
Remove actions dropdown from files list
LukasHirt Oct 30, 2020
12ef743
Create actions accordion and move mixin logic into it
LukasHirt Oct 30, 2020
545ec5a
Display sidebar also in trashbin
LukasHirt Oct 30, 2020
003cf7d
Reset highlighted file after restore
LukasHirt Oct 30, 2020
60a098d
Adjust spacing
LukasHirt Oct 30, 2020
e191279
Separate file actions into own mixins
LukasHirt Nov 2, 2020
156b3a2
Bring back default actions
LukasHirt Nov 2, 2020
82dffa8
Do not load preview in trashbin
LukasHirt Nov 2, 2020
8fad218
Change color and font-weight of buttons
LukasHirt Nov 2, 2020
387f28e
Fix lint errors
LukasHirt Nov 2, 2020
6d7c03f
Adjust selector for actions
LukasHirt Nov 2, 2020
ca058ef
Move versions on the last position
LukasHirt Nov 3, 2020
dec45ee
Expect actions panel isntead of versions
LukasHirt Nov 3, 2020
49936d4
Fix newFileActions
LukasHirt Nov 3, 2020
33e6250
Test if resource can be deleted in favorites list
LukasHirt Nov 3, 2020
118139a
Fix rename dialog error messages
LukasHirt Nov 3, 2020
646ff68
Fix status indicators handler
LukasHirt Nov 3, 2020
2fbf468
Fix location picker
LukasHirt Nov 3, 2020
791d150
Fix lint error
LukasHirt Nov 3, 2020
3958d3d
Open actions accordion when clicking on three dots icon
LukasHirt Nov 3, 2020
979d602
Update ODS
LukasHirt Nov 4, 2020
bbc2d53
Adjust rename tests
LukasHirt Nov 4, 2020
eb97d81
Display path also in favorites list
LukasHirt Nov 4, 2020
672fc54
Adjust switching tabs tests
LukasHirt Nov 4, 2020
e421c06
Adjust sharing tests
LukasHirt Nov 4, 2020
a082cab
Fix upload test
LukasHirt Nov 4, 2020
8144b04
Close sidebar before checking if resource is listed
LukasHirt Nov 5, 2020
3059834
Fix sharing tests
LukasHirt Nov 5, 2020
3b5aed4
Use "folder-open" icon for right sidebar
kulmann Nov 6, 2020
1565df9
Changelog items
kulmann Nov 6, 2020
ed7a63f
Fix a failing acceptance tests for share indicators
dpakach Nov 13, 2020
f08cb3c
Merge branch 'move-actions-to-sidebar' of github.com:owncloud/phoenix…
LukasHirt Nov 13, 2020
7f570fb
Skip failing scenario on ocis
LukasHirt Nov 13, 2020
dfe6b31
Add actions-icon and accordion-item horizontal padding
kulmann Nov 13, 2020
327c90f
Fix small bugs
LukasHirt Nov 15, 2020
8e6384b
Unskip trashbin test, check for share perm and check for route in bat…
LukasHirt Nov 16, 2020
127d0d7
Fix the check for move and copy buttons
LukasHirt Nov 16, 2020
213e305
Fix sharing test
kulmann Nov 16, 2020
489850b
Fix another share test
kulmann Nov 16, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion apps/draw-io/src/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,14 @@ const appInfo = {
menuTitle($gettext) {
return $gettext('New draw.io document…')
}
}
},
routes: [
'files-list',
'files-favorites',
'files-shared-with-others',
'files-shared-with-me',
'public-files'
]
}
]
}
Expand Down
37 changes: 3 additions & 34 deletions apps/files/src/components/AllFilesList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@
id="files-list"
:file-data="fileData"
:loading="loadingFolder"
:actions="actions"
:compact-mode="_sidebarOpen"
:is-action-enabled="isActionEnabled"
:has-two-rows="true"
:actions-enabled="true"
>
<template #headerColumns>
<div ref="headerNameColumn" class="uk-text-truncate uk-text-meta uk-width-expand">
Expand Down Expand Up @@ -51,29 +50,7 @@
</sortable-column-header>
</div>
</template>
<template #rowColumns="{ item: rowItem, index }">
<div
:ref="index === 0 ? 'firstRowNameColumn' : null"
class="uk-width-expand uk-flex uk-flex-middle"
>
<file-item
:key="rowItem.viewId"
:item="rowItem"
:show-path="$_isFavoritesList"
:indicators="indicatorArray(rowItem)"
:has-two-rows="true"
@click.native.stop="
rowItem.type === 'folder'
? navigateTo(rowItem.path.substr(1))
: triggerDefaultFileAction(rowItem)
"
/>
<oc-spinner
v-if="actionInProgress(rowItem)"
:uk-tooltip="disabledActionTooltip(rowItem)"
class="oc-ml-s"
/>
</div>
<template #rowColumns="{ item: rowItem }">
<div
class="uk-text-meta uk-text-nowrap uk-width-small uk-text-right"
:class="{ 'uk-visible@s': !_sidebarOpen, 'uk-hidden': _sidebarOpen }"
Expand Down Expand Up @@ -141,26 +118,22 @@
</template>
<script>
import FileList from './FileList.vue'
import FileItem from './FileItem.vue'
import NoContentMessage from './NoContentMessage.vue'
import QuickActions from './FilesLists/QuickActions.vue'
import SortableColumnHeader from './FilesLists/SortableColumnHeader.vue'

import { mapGetters, mapActions, mapState } from 'vuex'
import Mixins from '../mixins'
import MixinsFilesListIndicators from '../mixins/filesListIndicators'
import FileActions from '../fileactions'

export default {
name: 'AllFilesList',
components: {
FileList,
FileItem,
NoContentMessage,
SortableColumnHeader,
QuickActions
},
mixins: [Mixins, FileActions, MixinsFilesListIndicators],
mixins: [Mixins],
props: {
fileData: {
type: Array,
Expand Down Expand Up @@ -270,10 +243,6 @@ export default {
}
})
})
},

isActionEnabled(item, action) {
return action.isEnabled(item, this.parentFolder)
}
}
}
Expand Down
48 changes: 16 additions & 32 deletions apps/files/src/components/Collaborators/SharedFilesList.vue
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
id="files-list"
:file-data="fileData"
:loading="loadingFolder"
:actions="actions"
:compact-mode="_sidebarOpen"
:is-action-enabled="isActionEnabled"
:actions-enabled="true"
>
<template #headerColumns>
<div class="uk-text-truncate uk-text-meta uk-width-expand">
Expand All @@ -21,7 +20,8 @@
<div
v-if="!$_isSharedWithMe"
key="shared-with-header-cell"
class="uk-visible@s uk-text-nowrap uk-text-meta uk-width-medium uk-text-right"
class="uk-text-nowrap uk-text-meta uk-width-medium uk-text-right"
:class="{ 'uk-visible@s': !_sidebarOpen, 'uk-hidden': _sidebarOpen }"
translate-context="'People' table column"
v-text="$gettext('Shared with')"
/>
Expand All @@ -37,11 +37,15 @@
<div
v-if="$route.name === 'files-shared-with-me'"
key="shared-with-header-cell"
class="uk-visible@s uk-text-nowrap uk-text-meta uk-width-small uk-text-right"
class="uk-text-nowrap uk-text-meta uk-width-small uk-text-right"
:class="{ 'uk-visible@s': !_sidebarOpen, 'uk-hidden': _sidebarOpen }"
translate-context="Owner table column"
v-text="$gettext('Owner')"
/>
<div class="uk-visible@s uk-text-nowrap uk-text-meta uk-width-small">
<div
class="uk-text-nowrap uk-text-meta uk-width-small"
:class="{ 'uk-visible@s': !_sidebarOpen, 'uk-hidden': _sidebarOpen }"
>
<sortable-column-header
:aria-label="$gettext('Sort files by share time')"
:is-active="fileSortField == 'shareTimeMoment'"
Expand All @@ -55,26 +59,11 @@
<div class="oc-icon" />
</template>
<template #rowColumns="{ item }">
<div class="uk-width-expand uk-flex uk-flex-middle">
<file-item
:key="item.path"
:item="item"
@click.native.stop="
item.type === 'folder'
? navigateTo(item.path.substr(1))
: triggerDefaultFileAction(item)
"
/>
<oc-spinner
v-if="actionInProgress(item)"
:uk-tooltip="disabledActionTooltip(item)"
class="oc-ml-s"
/>
</div>
<div
v-if="!$_isSharedWithMe"
key="shared-with-cell"
class="uk-visible@s uk-text-meta uk-text-nowrap uk-text-truncate uk-width-medium uk-flex file-row-collaborators uk-flex-right"
class="uk-text-meta uk-text-nowrap uk-text-truncate uk-width-medium uk-flex file-row-collaborators uk-flex-right"
:class="{ 'uk-visible@s': !_sidebarOpen, 'uk-hidden': _sidebarOpen }"
>
<span
v-for="share in prepareCollaborators(item.shares)"
Expand Down Expand Up @@ -137,7 +126,8 @@
<div
v-if="$_isSharedWithMe"
key="shared-from-cell"
class="uk-visible@s uk-text-meta uk-text-nowrap uk-text-truncate uk-width-small uk-flex uk-flex-middle file-row-collaborators uk-flex-right"
class="uk-text-meta uk-text-nowrap uk-text-truncate uk-width-small uk-flex uk-flex-middle file-row-collaborators uk-flex-right"
:class="{ 'uk-visible@s': !_sidebarOpen, 'uk-hidden': _sidebarOpen }"
>
<avatar-image
class="oc-mr-xs"
Expand All @@ -148,7 +138,8 @@
<span class="file-row-owner-name" v-text="item.shareOwner.displayName" />
</div>
<div
class="uk-visible@s uk-text-meta uk-text-nowrap uk-width-small uk-text-right"
class="uk-text-meta uk-text-nowrap uk-width-small uk-text-right"
:class="{ 'uk-visible@s': !_sidebarOpen, 'uk-hidden': _sidebarOpen }"
v-text="formDateFromNow(item.shareTime)"
/>
</template>
Expand All @@ -173,9 +164,7 @@
<script>
import { mapGetters, mapActions } from 'vuex'
import Mixins from '../../mixins'
import FileActions from '../../fileactions'
import FileList from '../FileList.vue'
import FileItem from '../FileItem.vue'
import NoContentMessage from '../NoContentMessage.vue'
import SortableColumnHeader from '../FilesLists/SortableColumnHeader.vue'
import { shareTypes } from '../../helpers/shareTypes'
Expand All @@ -185,11 +174,10 @@ export default {
name: 'SharedFilesList',
components: {
FileList,
FileItem,
NoContentMessage,
SortableColumnHeader
},
mixins: [Mixins, FileActions],
mixins: [Mixins],
props: {
/**
* Array of active files
Expand Down Expand Up @@ -299,10 +287,6 @@ export default {
})
},

isActionEnabled(item, action) {
return action.isEnabled(item, null)
},

shareStatus(status) {
if (status === 0) return

Expand Down
Loading