[tests-only] make rename function in tests async #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
approved these changes
Aug 13, 2020
individual-it
force-pushed
the
renameAsync
branch
from
7c68c4b to
d874cac
Compare
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make the fuction to rename a file work async as other are already
Related Issue
owncloud/ocis#450
Motivation and Context
nightwatch would crash ugly when
waitForElementNotVisiblefails and the reported error would not be helpfulHow Has This Been Tested?
🤖
trying failing test with owncloud/ocis#409
Types of changes
Checklist:
Open tasks: