Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Improve TUS error handling #3472

Closed
wants to merge 1 commit into from
Closed

WIP Improve TUS error handling #3472

wants to merge 1 commit into from

Conversation

PVince81
Copy link
Contributor

Description

Abort directly for known error codes.
Added TODO to parse error message.

Related Issue

For https://github.com/owncloud/ocis-reva/issues/200
Requires TUS client support for retry callback: tus/tus-js-client#198

Motivation and Context

How Has This Been Tested?

Not tested yet

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

Abort directly for known error codes.
Added TODO to parse error message.
@PVince81 PVince81 self-assigned this May 18, 2020
@update-docs
Copy link

update-docs bot commented May 18, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@PVince81 PVince81 removed their assignment Sep 3, 2020
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Vincent Petry seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kulmann
Copy link
Contributor

kulmann commented Jun 25, 2021

Thanks for the ideas. We'll have a look at the new tus-js-client 2.3.0 soonish. Added this PR for reference in this ticket, so that we can give it another try after the upgrade.

@kulmann kulmann closed this Jun 25, 2021
@pascalwengerter pascalwengerter deleted the tus-error-handling branch June 29, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants