Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC][Theming] css custom properties #2668

Closed
wants to merge 4 commits into from

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Dec 10, 2019

Description

POC of css custom properties with ponyfill.

Related Issue

Motivation and Context

Enable runtime theming

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Try a different approach to load the theme
  • Test with extension
  • Test with web component
  • Test in IE11
  • Test with web component in IE11

@LukasHirt LukasHirt self-assigned this Dec 10, 2019
@LukasHirt
Copy link
Collaborator Author

Potential limitation - Ponyfill for ie11 is watching for changes only

when a <link> or <style> element is added, removed, or has its disabled or href attribute modified

Ref - https://jhildenbiddle.github.io/css-vars-ponyfill/#/?id=watch

@LukasHirt LukasHirt closed this Jan 7, 2020
@pascalwengerter pascalwengerter deleted the poc/css-custom-properties branch May 10, 2021 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant