Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web-app-preview): optionally access route query #12112

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Jan 17, 2025

Description

When filtering out files in preview app, access route query optionally in case it is undefined to prevent broken loading.

Related Issue

Motivation and Context

The app loads even when the route query got somehow lost.

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: added unit test
  • test case 2: open the editor without the route query

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

When filtering out files in preview app, access route query optionally in case it is undefined to prevent broken loading.
@LukasHirt LukasHirt force-pushed the fix(web-app-preview)/missing-route-query branch from f9849a6 to 2218d17 Compare January 17, 2025 10:32
@LukasHirt LukasHirt enabled auto-merge January 17, 2025 10:35
@anon-pradip
Copy link
Contributor

Thanks. Checked and fixes the issue: #12106

@saw-jan
Copy link
Member

saw-jan commented Jan 17, 2025

Also fixes #12108
Click on Preview action doesn't do anything. so it's good for this PR.

@LukasHirt LukasHirt merged commit 5ef8976 into master Jan 17, 2025
4 checks passed
@LukasHirt LukasHirt deleted the fix(web-app-preview)/missing-route-query branch January 17, 2025 11:54
@nirajacharya2 nirajacharya2 mentioned this pull request Jan 31, 2025
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
3 participants