Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable] refactor: switch to upstream uppy on stable #12053

Closed

Conversation

dschmidt
Copy link
Member

Description

This is basically a backport of #12052 -

Related Issue

Motivation and Context

I would usually not recommend this kind of change on the stable branch, but if we want to update Uppy and Companion in the relevant production setup, we need it.

Up to you @kobergj @LukasHirt

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

Copy link

update-docs bot commented Dec 20, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Dec 20, 2024

CLA assistant check
All committers have signed the CLA.

@dschmidt dschmidt changed the base branch from master to stable-11.0 December 20, 2024 15:31
@dschmidt dschmidt force-pushed the refactor/switch-to-upstream-uppy-on-stable branch from 44d5556 to ca4868d Compare December 20, 2024 15:32
@LukasHirt
Copy link
Collaborator

I would usually not recommend this kind of change on the stable branch, but if we want to update Uppy and Companion in the relevant production setup, we need it.

We discussed this with @kobergj and we will not include it in the next stable release (11.1.0) as we already are going to backport new notifications settings and we want to keep the release very lean.

@dschmidt
Copy link
Member Author

ok, so do you want to merge it to this stable branch after the release or shall we close this PR and target only the main branch?

@LukasHirt
Copy link
Collaborator

Release is planned for January. I'd say let's drop this PR now and we can later on bring it together probably also with some bugfixes in one new PR. But I'd prefer @kobergj to confirm this.

@kobergj
Copy link
Contributor

kobergj commented Dec 24, 2024

Sounds good to me 👍🏻

@dschmidt dschmidt closed this Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants