Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show missing role name in link share panel #12012

Merged
merged 4 commits into from
Dec 5, 2024
Merged

Show missing role name in link share panel #12012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
555a047
Show missing role name in link share panel
AlexAndBear Dec 5, 2024
8369331
Enhance changelog item
AlexAndBear Dec 5, 2024
364e3f1
Rm dev code
AlexAndBear Dec 5, 2024
b53730f
Code style
AlexAndBear Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions changelog/unreleased/bugfix-show-missing-role-name-in-link-share-panel
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Show missing role name in link share panel

We've fixed a bug where the role name was missing in the link share panel.

https://github.com/owncloud/web/pull/12012
11 changes: 10 additions & 1 deletion packages/web-pkg/src/components/CreateLinkModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@
</div>
<div v-else class="oc-flex oc-flex-middle">
<oc-icon class="oc-mr-s" :name="selectedTypeIcon" fill-type="line" />
<span v-text="selectedTypeDescription" />
<div class="oc-flex oc-flex-column">
<span class="oc-text-bold" v-text="selectedTypeDisplayName" />
<span class="oc-text-small" v-text="selectedTypeDescription" />
</div>
</div>
<oc-button
v-if="!isAdvancedMode"
Expand Down Expand Up @@ -187,6 +190,11 @@ export default defineComponent({
const selectedTypeDescription = computed(() =>
$gettext(getLinkRoleByType(unref(selectedType)).description)
)

const selectedTypeDisplayName = computed(() =>
$gettext(getLinkRoleByType(unref(selectedType)).displayName)
)

const selectedTypeIcon = computed(() => getLinkRoleByType(unref(selectedType)).icon)

const availableLinkTypes = computed(() => getAvailableLinkTypes({ isFolder: unref(isFolder) }))
Expand Down Expand Up @@ -313,6 +321,7 @@ export default defineComponent({
availableLinkTypes,
selectedType,
selectedTypeIcon,
selectedTypeDisplayName,
selectedTypeDescription,
isSelectedLinkType,
updateSelectedLinkType,
Expand Down