Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: soothe right sidebar panel transitions #11614

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Sep 20, 2024

Description

Soothe right sidebar transitions when opening and closing sub panels.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Visual

(Added by @tbsbdr )

Before and after for better comparison:

screenshot_003149.mp4

@JammingBen JammingBen self-assigned this Sep 20, 2024
@JammingBen JammingBen force-pushed the feat/soothe-sidebar-transition branch from 257a1cb to f734f61 Compare September 20, 2024 06:34
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to say that I'm not super hyped about the animation itself. But it is a lot more peaceful like this, so let's try that, definitely an improvement. 🚀
Another 👍 for fixing the glitch with the sidebar header 😅

@JammingBen
Copy link
Contributor Author

I have to say that I'm not super hyped about the animation itself. But it is a lot more peaceful like this, so let's try that, definitely an improvement.

Do you have something in mind that you'd like better? It's about 1:1 the animation from e.g. the iOS settings, which I find to be pretty much perfect in terms of subtle but also noticible.

@JammingBen JammingBen force-pushed the feat/soothe-sidebar-transition branch from f734f61 to 6f7a03e Compare September 20, 2024 06:53
@kulmann
Copy link
Contributor

kulmann commented Sep 20, 2024

Do you have something in mind that you'd like better? It's about 1:1 the animation from e.g. the iOS settings, which I find to be pretty much perfect in terms of subtle but also noticible.

Ooooh now we're talking. With your latest change, the root panel is not in a static position anymore, but gets pushed out a little bit to the left. That looks smooth, calm and awesome now 💪

@JammingBen JammingBen force-pushed the feat/soothe-sidebar-transition branch 2 times, most recently from 6bf0773 to 2020b37 Compare September 20, 2024 07:53
@tbsbdr
Copy link

tbsbdr commented Sep 20, 2024

I like it a lot, thanks!

@JammingBen JammingBen force-pushed the feat/soothe-sidebar-transition branch from 2020b37 to 03e10f9 Compare September 20, 2024 08:36
Copy link

@JammingBen JammingBen merged commit 0a3f222 into master Sep 20, 2024
3 checks passed
@JammingBen JammingBen deleted the feat/soothe-sidebar-transition branch September 20, 2024 08:58
@micbar micbar mentioned this pull request Oct 1, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants