Skip to content

Commit

Permalink
Merge pull request #11252 from owncloud/feat/remove-draw-io
Browse files Browse the repository at this point in the history
feat!: remove draw-io from default apps
  • Loading branch information
JammingBen authored Jul 22, 2024
2 parents 2e42581 + 0b69467 commit 6f86dd2
Show file tree
Hide file tree
Showing 19 changed files with 16 additions and 342 deletions.
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ The backbone of this project is built by the following parts of the `packages`:
- **runtime:** Central place of (user) authentication, provisioning of the user interface layout, client side storage, routing, theming, dependencies and (sub)application handling

The repository's `packages` also contains the following apps, which can be en-/disabled via the `config.json`:
- **draw-io:** An extension for creating, opening and editing `.draw` files
- **external:** An extension for creating, opening and editing files using the WOPI server
- **files:** The default extension and core part of the project, responsible for file sync-and-share - up- and downloading, sharing with other users/groups or via links, version management and more
- **pdf-viewer:** An extension for opening PDF files without leaving the UI
Expand Down
8 changes: 8 additions & 0 deletions changelog/unreleased/change-remove-draw-io
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
Change: Remove draw-io as default app

BREAKING CHANGE: draw-io has been removed as default web app. The app is now available via the [web-extensions repository](https://github.com/owncloud/web-extensions).

Please refer to [the web-app docs](https://owncloud.dev/services/web/#web-apps) to see how to load an external web app.

https://github.com/owncloud/web/pull/11252
https://github.com/owncloud/web/issues/11248
1 change: 0 additions & 1 deletion config/config.json.dist
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
"authUrl": ""
},
"apps" : [
"draw-io",
"files",
"pdf-viewer",
"preview",
Expand Down
1 change: 0 additions & 1 deletion config/config.json.sample-ocis
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
"pdf-viewer",
"search",
"text-editor",
"draw-io",
"external",
"admin-settings",
"epub-reader"
Expand Down
8 changes: 0 additions & 8 deletions dev/docker/ocis.web-federated.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,6 @@
"mimeTypes": ["image/tiff", "image/bmp", "image/x-ms-bmp"]
}
},
{
"id": "draw-io",
"path": "web-app-draw-io",
"config": {
"url": "https://embed.diagrams.net",
"theme": "minimal"
}
},
{
"id": "importer",
"path": "web-app-importer",
Expand Down
8 changes: 0 additions & 8 deletions dev/docker/ocis.web.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,14 +35,6 @@
"mimeTypes": ["image/tiff", "image/bmp", "image/x-ms-bmp"]
}
},
{
"id": "draw-io",
"path": "web-app-draw-io",
"config": {
"url": "https://embed.diagrams.net",
"theme": "minimal"
}
},
{
"id": "importer",
"path": "web-app-importer",
Expand Down
3 changes: 1 addition & 2 deletions docs/deployments/oc10-app.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,7 @@ There are a few config values which need to be set in order for ownCloud Web to
"apps" : [
"files",
"preview",
"search",
"draw-io"
"search"
],
"applications" : [
{
Expand Down
1 change: 0 additions & 1 deletion docs/development/repo-structure.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,6 @@ Both `web-app-admin-settings` and `web-app-files` are standalone apps which are
Apps which fall into the categories `viewer` or `editor` can be opened from the context of a file or folder. This mostly happens from
within the `files` app. We currently bundle the following apps with the default ownCloud Web release artifact:

- `web-app-draw-io` an editor for `.drawio` files
- `web-app-external` an iframe integration of all the apps coming from the [app provider](https://owncloud.dev/services/app-provider/)
(e.g. OnlyOffice, Collabora Online and others)
- `web-app-pdf-viewer` a viewer for `.pdf` files, which relies on native PDF rendering support from the browser
Expand Down
2 changes: 1 addition & 1 deletion docs/extension-system/viewer-editor-apps.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ This section will guide you through the process of implementing such an app with

An app is essentially a distinct package that must be specified as an external application in the Web configuration.

The structure of an app is quite simple and straightforward. Consider, for example, the [draw.io app](https://github.com/owncloud/web/tree/master/packages/web-app-draw-io). It consists of a `package.json` file, a `src` directory containing all the source code, and a `l10n` directory for translations. Optionally, you may also include a `tests` directory if your application requires testing.
The structure of an app is quite simple and straightforward. Consider, for example, the [pdf-viewer app](https://github.com/owncloud/web/tree/master/packages/web-app-pdf-viewer). It consists of a `package.json` file, a `src` directory containing all the source code, and a `l10n` directory for translations. Optionally, you may also include a `tests` directory if your application requires testing.

To learn more about apps in general, please refer to the [Web app docs]({{< ref "_index.md#apps" >}}).

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"serve": "SERVER=true pnpm build:w",
"test:e2e:cucumber": "NODE_TLS_REJECT_UNAUTHORIZED=0 TS_NODE_PROJECT=./tests/e2e/cucumber/tsconfig.json cucumber-js --profile=e2e -f json:tests/e2e/cucumber/report/cucumber_report.json",
"test:unit": "NODE_OPTIONS=--unhandled-rejections=throw vitest",
"licenses:check": "license-checker-rseidelsohn --summary --relativeLicensePath --onlyAllow 'Python-2.0;Apache*;Apache License, Version 2.0;Apache-2.0;Apache 2.0;Artistic-2.0;BSD;BSD-3-Clause;CC-BY-3.0;CC-BY-4.0;CC0-1.0;ISC;MIT;MPL-2.0;Public Domain;Unicode-TOU;Unlicense;WTFPL' --excludePackages '@ownclouders/babel-preset;@ownclouders/eslint-config;@ownclouders/prettier-config;@ownclouders/tsconfig;@ownclouders/web-client;@ownclouders/web-pkg;draw-io;external;web-app-files;text-editor;preview;web-app-ocm;@ownclouders/design-system;pdf-viewer;web-app-search;admin-settings;webfinger;web-runtime'",
"licenses:check": "license-checker-rseidelsohn --summary --relativeLicensePath --onlyAllow 'Python-2.0;Apache*;Apache License, Version 2.0;Apache-2.0;Apache 2.0;Artistic-2.0;BSD;BSD-3-Clause;CC-BY-3.0;CC-BY-4.0;CC0-1.0;ISC;MIT;MPL-2.0;Public Domain;Unicode-TOU;Unlicense;WTFPL' --excludePackages '@ownclouders/babel-preset;@ownclouders/eslint-config;@ownclouders/prettier-config;@ownclouders/tsconfig;@ownclouders/web-client;@ownclouders/web-pkg;external;web-app-files;text-editor;preview;web-app-ocm;@ownclouders/design-system;pdf-viewer;web-app-search;admin-settings;webfinger;web-runtime'",
"licenses:csv": "license-checker-rseidelsohn --relativeLicensePath --csv --out ./third-party-licenses/third-party-licenses.csv",
"licenses:save": "license-checker-rseidelsohn --relativeLicensePath --out /dev/null --files ./third-party-licenses/third-party-licenses",
"vite": "vue-demi-fix && vite",
Expand Down
9 changes: 0 additions & 9 deletions packages/web-app-draw-io/l10n/.tx/config

This file was deleted.

1 change: 0 additions & 1 deletion packages/web-app-draw-io/l10n/translations.json

This file was deleted.

16 changes: 0 additions & 16 deletions packages/web-app-draw-io/package.json

This file was deleted.

173 changes: 0 additions & 173 deletions packages/web-app-draw-io/src/App.vue

This file was deleted.

65 changes: 0 additions & 65 deletions packages/web-app-draw-io/src/index.ts

This file was deleted.

19 changes: 0 additions & 19 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 6f86dd2

Please sign in to comment.