Merge pull request #6955 from owncloud/remove-link-from-share-notific…

…ation Remove private links from share notifications
owncloud · May 12, 2022 · 66ce764 · 66ce764
2 parents 9c9ef2c + 42c113a
commit 66ce764
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/changelog/unreleased/bugfix-remove-links-from-share-notifications b/changelog/unreleased/bugfix-remove-links-from-share-notifications
@@ -0,0 +1,6 @@
+Bugfix: Remove private links from share notifications
+
+We've removed private links from share notifications because those were not working and also not needed.
+
+https://github.com/owncloud/web/pull/6955
+https://github.com/owncloud/web/issues/5227
diff --git a/packages/web-runtime/src/components/Topbar/Notifications.vue b/packages/web-runtime/src/components/Topbar/Notifications.vue
@@ -26,7 +26,7 @@
         <h4 v-text="el.subject" />
         <p v-if="el.message" class="oc-text-small">{{ el.message }}</p>
         <p>
-          <a v-if="el.link" :href="el.link" target="_blank">{{ el.link }}</a>
+          <a v-if="shouldDisplayLink(el)" :href="el.link" target="_blank">{{ el.link }}</a>
         </p>
         <div class="oc-width-1-1 oc-flex-right">
           <template v-if="el.actions.length !== 0">
@@ -106,6 +106,9 @@ export default {
           status: 'danger'
         })
       })
+    },
+    shouldDisplayLink(notification) {
+      return notification.link && notification.object_type !== 'local_share'
     }
   }
 }