Skip to content

Commit

Permalink
Merge pull request #5691 from owncloud/openidLogin-scenario-fix
Browse files Browse the repository at this point in the history
[tests-only] [full-ci] Fix openIdLogin scenario for login with invalid password
  • Loading branch information
phil-davis authored Aug 18, 2021
2 parents eda806d + aac38aa commit 3e68776
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ Other free text and markdown formatting can be used elsewhere in the document if
- [webUIPreview/imageMediaViewer.feature:191](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPreview/imageMediaViewer.feature#L191)

### [Exit page re-appears in loop when logged in user is deleted](https://github.com/owncloud/web/issues/4677)
- [webUILogin/openidLogin.feature:51](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUILogin/openidLogin.feature#L51)
- [webUILogin/openidLogin.feature:50](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUILogin/openidLogin.feature#L50)

### [REPORT request not implemented](https://github.com/owncloud/ocis/issues/1330)
- [webUIDeleteFilesFolders/deleteFilesFolders.feature:295](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIDeleteFilesFolders/deleteFilesFolders.feature#L295)
Expand Down Expand Up @@ -206,10 +206,6 @@ Other free text and markdown formatting can be used elsewhere in the document if
- [webUISharingInternalUsersBlacklisted/shareWithUsers.feature:82](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalUsersBlacklisted/shareWithUsers.feature#L82)
- [webUISharingInternalGroups/shareWithGroups.feature:200](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature#L200)

### [Can login with invalid password while logging in with openidconnect in oc10](https://github.com/owncloud/ocis/issues/1428)
- [webUILogin/openidLogin.feature:44](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUILogin/openidLogin.feature#L44)


### webUI-Private-Links
- [webUIPrivateLinks/accessingPrivateLinks.feature:9](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L9)
- [webUIPrivateLinks/accessingPrivateLinks.feature:17](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIPrivateLinks/accessingPrivateLinks.feature#L17)
Expand Down
6 changes: 3 additions & 3 deletions tests/acceptance/features/webUILogin/openidLogin.feature
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,11 @@ Feature: login users
When the user tries to log in with username "invalid" and password "1234" using the webUI
Then the warning 'Logon failed. Please verify your credentials and try again.' should be displayed on the login page

@ocis-konnectd-issue-68

Scenario: try to login with valid username and invalid password
Given the user has browsed to the login page
When the user tries to log in with username "Alice" and password "invalid" using the webUI
Then the files table should be displayed
# Then the warning 'Logon failed. Please verify your credentials and try again.' should be displayed on the login page
Then the warning 'Logon failed. Please verify your credentials and try again.' should be displayed on the login page


Scenario: the user session of a deleted user is cleared properly
Expand All @@ -57,6 +56,7 @@ Feature: login users
When the user exits the login error page
Then the user should be redirected to the login page


Scenario: the user session of a deleted user should not be valid for newly created user of same name
Given user "Alice" has logged in using the webUI
And user "Alice" has been deleted
Expand Down

0 comments on commit 3e68776

Please sign in to comment.