Skip to content

Commit

Permalink
Fix via-URLs for link & collaborator shares
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalwengerter committed May 18, 2021
1 parent 28b0e78 commit 1d87b6c
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 13 deletions.
7 changes: 7 additions & 0 deletions changelog/unreleased/bugfix-navigate-to-share-parent
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Correct navigation through "via"-tags

The links in the indirect share tags in the sidebar were
navigating to the parent directory of the indirect share entry.
This has been fixed and the link target is the share entry itself now.

https://github.com/owncloud/web/pull/5122
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@
import { mapGetters } from 'vuex'
import moment from 'moment'
import { shareTypes } from '../../helpers/shareTypes'
import { basename, dirname } from 'path'
import { basename } from 'path'
import CollaboratorsMixins from '../../mixins/collaborators'
import Mixins from '../../mixins'
Expand Down Expand Up @@ -249,14 +249,10 @@ export default {
},
viaRouterParams() {
const viaPath = this.collaborator.path
return {
name: 'files-personal',
params: {
item: dirname(viaPath) || '/'
},
query: {
scrollTo: basename(viaPath)
item: this.collaborator.path || '/'
}
}
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@
</template>

<script>
import { basename, dirname } from 'path'
import { basename } from 'path'
import Mixins from '../../mixins'
export default {
Expand Down Expand Up @@ -128,15 +128,10 @@ export default {
},
viaRouterParams() {
const viaPath = this.link.path
return {
name: 'files-personal',
params: {
item: dirname(viaPath) || '/'
},
query: {
scrollTo: basename(viaPath)
item: this.link.path || '/'
}
}
},
Expand Down

0 comments on commit 1d87b6c

Please sign in to comment.