This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Prevent logging unsafe header error #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
approved these changes
Apr 24, 2020
|
Backend that don't support TUS will also not expose TUS headers through CORS. To prevent the uncatchable "refused to get unsafe header", this commit adds a workaround with a preliminary check using "getAllResponseHeaders" to find out if the header is exposed by CORS before reading it.
PVince81
force-pushed
the
prevent-unsafe-header-log
branch
from
ae7c71d to
e95bcd7
Compare
|
I've fixed the tests by lower casing the "all headers" call, since the mocker from sinon did not lower case by default. It might also increase compatibility in case some browsers do not lower case by default either. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backend that don't support TUS will also not expose TUS headers through
CORS. To prevent the uncatchable "refused to get unsafe header", this
commit adds a workaround with a preliminary check using
"getAllResponseHeaders" to find out if the header is exposed by CORS
before reading it.
Fixes #462