This repository has been archived by the owner on Jun 5, 2024. It is now read-only.
Manipulate share type for oc10 guests #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAndBear
changed the title
kulmann
reviewed
Apr 25, 2022
kulmann
reviewed
Apr 25, 2022
DRAFT DRAFT DRAFT :D :D :D |
AlexAndBear
force-pushed
the
manipulate-share-type
branch
from
ce26d64 to
6c9e28a
Compare
AlexAndBear
commented
Apr 26, 2022
Comment on lines
-12
to
-13
| // Below keys don't need to be stored | ||
| const notNeededKeys = ['item_type', 'item_source', 'file_source', 'parent', 'storage', 'mail_send'] |
There was a problem hiding this comment.
we need the storage, and I have no idea, why we should purge those properties
AlexAndBear
force-pushed
the
manipulate-share-type
branch
from
919e352 to
df86311
Compare
kulmann
approved these changes
Apr 26, 2022
changelog/unreleased/enhancement-enforce-share-type-guest-if-applies
Outdated
Show resolved
Hide resolved
…pplies Co-authored-by: Benedikt Kulmann <benedikt@kulmann.biz>
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.