Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Redesign OcStatusIndicators, Remove OcStatusIndicators from OcResource #2014

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Redesign OcStatusIndicators, Remove OcStatusIndicators from OcResource #2014

merged 3 commits into from
Mar 9, 2022

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Mar 8, 2022 •
edited
Loading

Description

See owncloud/web#5976

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

@update-docs
Copy link

update-docs bot commented Mar 8, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

pascalwengerter
pascalwengerter suggested changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the fact that there's no failing tests after your changes speak for the fact that tests need to be improved 😬

@lookacat lookacat force-pushed the move-status-indicators branch from dc8460e to 20f8a29 Compare March 9, 2022 13:25
@lookacat lookacat marked this pull request as ready for review March 9, 2022 13:27
@lookacat lookacat changed the title Redesign OcStatusIndicators Redesign OcStatusIndicators, Remove OcStatusIndicators from OcResource Mar 9, 2022
@pascalwengerter
Copy link
Contributor

Is there a reason the link doesn't have the blue background? Or should it be a hover state thing?

Screenshot 2022-03-09 at 15-07-35 ownCloud Design System

@pascalwengerter
Copy link
Contributor

Is there a reason the link doesn't have the blue background? Or should it be a hover state thing?

Screenshot 2022-03-09 at 15-07-35 ownCloud Design System

Resolved, was a faulty example

@lookacat lookacat force-pushed the move-status-indicators branch from 8131eef to 5d2bd72 Compare March 9, 2022 15:55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

1 similar comment
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Mar 9, 2022
View reviewed changes
changelog/unreleased/enhancement-redesign-status-indicators
@@ -0,0 +1,8 @@
Enhancement: Redesign OcStatusIndicators

We've redesigned the share/status indicators to fit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In theory we did redesign them to fit the new UI better, but that doesn't matter too much 😉

@pascalwengerter pascalwengerter merged commit 8ed1762 into master Mar 9, 2022
@pascalwengerter pascalwengerter deleted the move-status-indicators branch March 9, 2022 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann left review comments

@pascalwengerter pascalwengerter pascalwengerter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lookacat @pascalwengerter @kulmann