Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add grouping functionality for tables #1838

Closed
wants to merge 4 commits into from

Conversation

elizavetaRa
Copy link
Member

@elizavetaRa elizavetaRa commented Dec 20, 2021

Description

Grouping as well as preview functionality for the tables, web part
Web part: #6165

Setup is done with the property "groupingSettings" . Following settings are possible:

  • groupingFunctions: Object with keys as grouping options names and functions that get a table data row and return a group name for that row. The names of the functions are used as grouping options.

  • groupingBy: must be either one of the keys in groupingFunctions or 'None'. If not set, default grouping will be 'None'.

  • ShowGroupingOptions: boolean value for showing or hinding the select element with grouping options above the table.

  • sortGroups: Object with keys as grouping options names and as values functions that get an array of groups and return a sorted array of groups.

Screenshot from 2021-09-08 10-47-39

Related Issue

Motivation and Context

UX-friendly option for better overviews of table contents

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [ x] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • [ x] Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

Open tasks:

  • Tests

@update-docs
Copy link

update-docs bot commented Dec 20, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@elizavetaRa elizavetaRa force-pushed the advanced_table branch 2 times, most recently from af0e2bd to 2e339fa Compare January 24, 2022 11:51
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add an example in the examples section of the OcTable.vue file which showcases a simple demo instance of an OcTable with grouping settings defined (examples are currently starting in line 930).

I see some issues in the template, e.g. a style="colspan='2'" which should just be :colspan="2". rowHeight is used in the template, but never defined. I can fix that and do some adjustments, but it would be good to have an example from you.

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2022

CLA assistant check
All committers have signed the CLA.

@elizavetaRa elizavetaRa force-pushed the advanced_table branch 2 times, most recently from 63efbe5 to 2931fb0 Compare January 31, 2022 15:07
@diocas
Copy link

diocas commented Feb 21, 2022

@kulmann @elizavetaRa looks like this got a conflict again. Is there anything else blocking it?

@elizavetaRa
Copy link
Member Author

I resolved the conflicts

@diocas
Copy link

diocas commented Mar 4, 2022

@kulmann Pascal said you had some comments about this PR, is there anything blocking?

@diocas
Copy link

diocas commented Mar 17, 2022

@kulmann you were going to create a separate PR for this, any update on it?

@kulmann
Copy link
Contributor

kulmann commented Mar 17, 2022

@kulmann you were going to create a separate PR for this, any update on it?

(edited - sorry, I misread your comment)
@fschade is working on a PR right now.

@fschade
Copy link
Contributor

fschade commented Mar 28, 2022

@elizavetaRa can you please have a look -> owncloud/web#6680 and link #2048 locally until it's merged and release.

@pascalwengerter
Copy link
Contributor

Closing this PR since we won't merge it in ODS this way. Corresponding work (including discussions) is being tracked/worked on in in the web repository, see

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants