-
Notifications
You must be signed in to change notification settings - Fork 19
Add grouping functionality for tables #1838
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
af0e2bd
to
2e339fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add an example in the examples section of the OcTable.vue
file which showcases a simple demo instance of an OcTable with grouping settings defined (examples are currently starting in line 930).
I see some issues in the template, e.g. a style="colspan='2'"
which should just be :colspan="2"
. rowHeight
is used in the template, but never defined. I can fix that and do some adjustments, but it would be good to have an example from you.
2e339fa
to
493ede7
Compare
63efbe5
to
2931fb0
Compare
@kulmann @elizavetaRa looks like this got a conflict again. Is there anything else blocking it? |
7da86af
to
12c582b
Compare
I resolved the conflicts |
a514df1
to
4819f4a
Compare
@kulmann Pascal said you had some comments about this PR, is there anything blocking? |
@kulmann you were going to create a separate PR for this, any update on it? |
@elizavetaRa can you please have a look -> owncloud/web#6680 and link #2048 locally until it's merged and release. |
Closing this PR since we won't merge it in ODS this way. Corresponding work (including discussions) is being tracked/worked on in in the web repository, see |
Description
Grouping as well as preview functionality for the tables, web part
Web part: #6165
Setup is done with the property "groupingSettings" . Following settings are possible:
groupingFunctions: Object with keys as grouping options names and functions that get a table data row and return a group name for that row. The names of the functions are used as grouping options.
groupingBy: must be either one of the keys in groupingFunctions or 'None'. If not set, default grouping will be 'None'.
ShowGroupingOptions: boolean value for showing or hinding the select element with grouping options above the table.
sortGroups: Object with keys as grouping options names and as values functions that get an array of groups and return a sorted array of groups.
Related Issue
Motivation and Context
UX-friendly option for better overviews of table contents
Types of changes
Checklist:
Open tasks: