Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] adjust expected-failure list and archive related tests #9864

Merged
merged 3 commits into from
Aug 23, 2024
Merged

[tests-only] adjust expected-failure list and archive related tests #9864

merged 3 commits into from
Aug 23, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Aug 20, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Aug 20, 2024
@saw-jan saw-jan mentioned this pull request Aug 20, 2024
Closed
@saw-jan saw-jan force-pushed the tests/adjust-expected-failure-list branch 2 times, most recently from 44e302f to 1d2cb27 Compare August 21, 2024 04:21
@saw-jan saw-jan marked this pull request as ready for review August 21, 2024 05:40
@saw-jan saw-jan force-pushed the tests/adjust-expected-failure-list branch from 1d2cb27 to 1da318f Compare August 22, 2024 04:21
@saw-jan saw-jan force-pushed the tests/adjust-expected-failure-list branch from 1da318f to 29b9f9b Compare August 22, 2024 09:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ScharfViktor
ScharfViktor reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

owncloud/web#11080
should we use zip for all users-agents in tests?

@saw-jan
Copy link
Member Author

saw-jan commented Aug 23, 2024 •
edited
Loading

owncloud/web#11080 should we use zip for all users-agents in tests?

But we still can get tar archive using output-format=tar query param. zip is the default one. IMO, let's test that output-format=tar works atleast via API.
@ScharfViktor What do you think? or is it planned to be removed?

@ScharfViktor
Copy link
Contributor

IMO, let's test that output-format=tar works atleast via API.

yeah, let leave it
But since we are using zip, I would check in the api that zip works for different user-agents.

Examples:
      | user-agent | archive-type |
      | Linux      | zip          |
      | Windows NT | tar          |
| Windows NT | zip        |

@saw-jan
Copy link
Member Author

saw-jan commented Aug 23, 2024

But since we are using zip, I would check in the api that zip works for different user-agents.

Yeah, I tried to mix-match the formats:

ocis/tests/acceptance/features/apiArchiver/downloadById.feature

Lines 24 to 26 in 29b9f9b

| user-agent | archive-type |
| Linux | tar |
| Windows NT | zip |

ocis/tests/acceptance/features/apiArchiver/downloadById.feature

Lines 42 to 44 in 29b9f9b

| user-agent | archive-type |
| Linux | zip |
| Windows NT | tar |

Will it be enough?

@ScharfViktor
Copy link
Contributor

Will it be enough?
yeah

@saw-jan saw-jan merged commit 917ac8e into master Aug 23, 2024
4 checks passed
@saw-jan saw-jan deleted the tests/adjust-expected-failure-list branch August 23, 2024 10:38
ownclouders pushed a commit that referenced this pull request Aug 23, 2024
@saw-jan
Merge pull request #9864 from owncloud/tests/adjust-expected-failure-…
fa9f25d 
…list

[tests-only] adjust expected-failure list and archive related tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@anon-pradip anon-pradip Awaiting requested review from anon-pradip

@ishabaral ishabaral Awaiting requested review from ishabaral

@prashant-gurung899 prashant-gurung899 Awaiting requested review from prashant-gurung899

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saw-jan @ScharfViktor @S-Panta