Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] add tests to PROPFIND extracted file props to Personal and Shares spaces #9606

Merged
merged 2 commits into from
Jul 17, 2024
Merged

[tests-only] add tests to PROPFIND extracted file props to Personal and Shares spaces #9606

merged 2 commits into from
Jul 17, 2024

Conversation

Salipa-Gurung
Copy link
Contributor

@Salipa-Gurung Salipa-Gurung commented Jul 15, 2024 •
edited
Loading

Description

Added scenarios for checking audio, location, image and photo props of the file from Personal space by space admin and Shares space by sharee.

Related Issue

How Has This Been Tested?

  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@Salipa-Gurung Salipa-Gurung self-assigned this Jul 15, 2024
@Salipa-Gurung Salipa-Gurung mentioned this pull request Jul 15, 2024
Closed
8 tasks
@Salipa-Gurung Salipa-Gurung marked this pull request as ready for review July 16, 2024 10:08
saw-jan
saw-jan approved these changes Jul 16, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ✨

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 4323c26 into master Jul 17, 2024
2 checks passed
@saw-jan saw-jan deleted the new-props-in-spaces branch July 17, 2024 05:56
ownclouders pushed a commit that referenced this pull request Jul 17, 2024
@saw-jan
Merge pull request #9606 from owncloud/new-props-in-spaces
27b71df 
[tests-only] add test coverage for new props from personal space
@saw-jan saw-jan changed the title [tests-only] add test coverage for new props from personal space [tests-only] add tests to PROPFIND extracted file props to Personal and Shares spaces Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

Assignees

@Salipa-Gurung Salipa-Gurung

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Salipa-Gurung @saw-jan