[docs-only] [chore] Update helper generated envvar yamls #9383
Conversation
|
There was a problem hiding this comment.
It is a bit difficult to know if all this stuff is correct. There are quite a few changes for introductionVersion between pre5.0 and 5.0 for example. Maybe those are all correct fixes for previous errors.
I am approving so that this can be merged, since any adjustments need to be done back in the sources anyway.
| type: int | ||
| description: The maximum quantity of items in the store. Only applies when store | ||
| type 'ocmem' is configured. Defaults to 512 which is derived from the ocmem package | ||
| though not exclicitely set as default. |
There was a problem hiding this comment.
| though not exclicitely set as default. | |
| though not explicitly set as default. |
I know that this text is being imported from elsewhere - so I suppose that I need to make a PR to the source, and then another PR can be done to fix the little stuff.
| @@ -1,3 +1,104 @@ | |||
| ACTIVITYLOG_SERVICE_ACCOUNT_ID: | |||
There was a problem hiding this comment.
Why are there various new env vars with introductionVersion: "5.0" ?
5.0 was released a while ago, so I expected that these would already exist in the docs.
| description: 'The type of the store. Supported values are: ''memory'', ''ocmem'', | ||
| ''etcd'', ''redis'', ''redis-sentinel'', ''nats-js'', ''noop''. See the text description | ||
| for details.' | ||
| introductionVersion: pre5.0 |
There was a problem hiding this comment.
This one is "pre5.0" - that seems weird - if the env var existed before 5.0, then why is it not already in the docs?
| description: The bind address of the gateway GRPC address. | ||
| introductionVersion: "5.0" | ||
| description: The bind address of the GRPC service. | ||
| introductionVersion: pre5.0 |
There was a problem hiding this comment.
I suppose that the introductionVersion was wrong previously, and someone reset it to "pre5.0"
|
Hmmm - looks like it auto-merged when I clicked approve! I hope that it doesn't "break the internet". |
[docs-only] [chore] Update helper generated envvar yamls
No it does not 🤣 I will file a new PR to correct the typo. Regarding 5.0 or pre5.0, this is all correct even it seems not to be so. The helper process gathers all stuff from the ocis code. Sometimes this can be a bit confusing like with Hope this makes it more clear. |
The
extended_vars.yamlandenv_vars.yamlneed regular update on envvar changes. This PR takes care on. Admin docs only relevant.