Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Add tests for create link using root endpoint #9076

Merged
merged 1 commit into from
May 10, 2024

Conversation

amrita-shrestha
Copy link
Contributor

Description

This PR adds tests for creating share link of drives using root endpoint

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@amrita-shrestha amrita-shrestha force-pushed the create-drive-root-share-link branch from d45bb86 to ae286c8 Compare May 9, 2024 08:03
@amrita-shrestha amrita-shrestha requested a review from saw-jan May 9, 2024 08:29
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should call:

  • user share
  • group share
  • link share

@amrita-shrestha amrita-shrestha force-pushed the create-drive-root-share-link branch from ae286c8 to 8988057 Compare May 10, 2024 05:06
@amrita-shrestha amrita-shrestha requested a review from saw-jan May 10, 2024 05:06
@amrita-shrestha amrita-shrestha force-pushed the create-drive-root-share-link branch from 8988057 to 0ab7e37 Compare May 10, 2024 05:08
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@amrita-shrestha amrita-shrestha merged commit 71ca659 into master May 10, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the create-drive-root-share-link branch May 10, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants