Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adding test for listing permission of personal drive #8901

Merged
merged 1 commit into from
Jul 8, 2024
Merged

[tests-only][full-ci] adding test for listing permission of personal drive #8901

merged 1 commit into from
Jul 8, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Apr 19, 2024 •
edited
Loading

Description

this pr adds test for listing permissions of personal drive

added scenarios

Scenario: list the permissions of a Personal drive using permissions endpoint

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Apr 19, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Apr 19, 2024
Closed
18 tasks
@nirajacharya2 nirajacharya2 force-pushed the list-perm-personal branch 3 times, most recently from c611a30 to 1643662 Compare April 22, 2024 04:06
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@nirajacharya2 nirajacharya2 marked this pull request as ready for review April 22, 2024 06:50
PrajwolAmatya
PrajwolAmatya previously approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

saw-jan
saw-jan requested changes Apr 23, 2024
View reviewed changes
tests/acceptance/features/apiSharingNg/listPermissions.feature Outdated
Comment on lines 1084 to 1085
Scenario: user lists the permissions of their personal spaces
When user "Alice" lists the permissions of space "Personal" using the Graph API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The response is different from using drives.root endpoint. Needs clarifications here.

Should listing permissions of Personal space's root path be possible?
this step uses drives.permissions. : drives/<drive-id>/items/<root-path-id>/permissions

CC @ScharfViktor @rhafer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using drives.root endpoint, it is not possible to list Personal space permissions

ocis/tests/acceptance/features/apiSharingNg/listPermissions.feature

Lines 1040 to 1045 in 0960d7f

Scenario Outline: try to lists the permissions of a Personal/Shares drive using root endpoint
Given using spaces DAV path
And the administrator has assigned the role "Space Admin" to user "Alice" using the Graph API
And user "Alice" has created a space "new-space" with the default quota using the Graph API
When user "Alice" tries to list the permissions of space "<drive>" using root endpoint of the Graph API
Then the HTTP status code should be "400"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made an issue regarding this #8922

@nirajacharya2
Copy link
Contributor Author

nirajacharya2 commented Apr 24, 2024 •
edited
Loading

currently blocked by #8922

@amrita-shrestha amrita-shrestha mentioned this pull request Apr 30, 2024
Closed
27 tasks
@nirajacharya2 nirajacharya2 force-pushed the list-perm-personal branch 2 times, most recently from a9ad01c to b0a527d Compare June 25, 2024 04:05
@nirajacharya2 nirajacharya2 requested a review from saw-jan June 25, 2024 08:48
@nirajacharya2 nirajacharya2 force-pushed the list-perm-personal branch 3 times, most recently from 8734cde to 4a934d8 Compare July 3, 2024 03:34
@nabim777
Copy link
Member

nabim777 commented Jul 8, 2024

CI failure:

error:      Not enough items in array at #->properties:@libre.graph.permissions.roles.allowedValues (Swaggest\JsonSchema\Exception\ArrayException)

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nabim777
nabim777 approved these changes Jul 8, 2024
View reviewed changes
Copy link
Member

@nabim777 nabim777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 if CI green 💚

@nabim777 nabim777 merged commit bc77a6a into master Jul 8, 2024
3 checks passed
@nabim777 nabim777 deleted the list-perm-personal branch July 8, 2024 09:06
ownclouders pushed a commit that referenced this pull request Jul 8, 2024
@nabim777
Merge pull request #8901 from owncloud/list-perm-personal
e72ebef 
[tests-only][full-ci] adding test for listing permission of personal drive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi approved these changes

@saw-jan saw-jan saw-jan approved these changes

@nabim777 nabim777 nabim777 approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@grgprarup grgprarup Awaiting requested review from grgprarup

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nirajacharya2 @nabim777 @SagarGi @saw-jan @PrajwolAmatya @ScharfViktor