[full-ci] fix(sharing-ng): Add /graph/v1beta1/drives/{driveId}/root endpoints
#8727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
rhafer
force-pushed
the
issue/8351
branch
9 times, most recently
from
928a59d to
a9b6246
Compare
rhafer
changed the title
/graph/v1beta1/drives/{driveId}/root endpoints /graph/v1beta1/drives/{driveId}/root endpoints
rhafer
force-pushed
the
issue/8351
branch
2 times, most recently
from
e131ce1 to
888012f
Compare
This introduces the new DriveItemPermissionsService and DriveItemPermissionsApi to allow for better separation of the business logic and the API handling. As a starting point the Invite method was moved to the new service. More to follow.
… methods BaseGraphService is a struct to hold common fields and methods that can be share between different service implementations. E.g. for converting CS3 objects to their libregraph equivalents.
kobergj
requested changes
Apr 4, 2024
This add support for the following graph routes:
POST /drives/{driveID}/root/createLink
DELETE /drives/{driveID}/root/permissions/{permissionID}
PATCH /drives/{driveID}/root/permissions/{permissionID}
and
POST /drives/{driveID}/root/permissions/{permissionID}/setPassword
This should significantly improve handling of permissions on spaces
as there is no need to figure to the drive's root itemid anymore.
Partial Fix: owncloud#8351
The default (10) seems somewhat low.
|
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: This might be easier to review if you look at the separate commits instead of the huge diff of the full PR. (Most of the commits are just moving code around)
This adds support for the the following endpoints:
Basically
rootworks as an alias for theitemidof root item of a drive. So this should make it easier to deal with permissions on project spaces.Apart from the above this PR does also quite a bit of refactoring, trying to move all permission related endpoints into separate service and splitting up the http request handling from the business logic. Which should make the code somewhat better to maintain and test. (there is still a lot of room for improvement though).