Define dispatch #846
Merged
Define dispatch #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
force-pushed
the
fix-dispatch-on-choose-account
branch
from
b643a7b to
62dd552
Compare
IljaN
approved these changes
Nov 12, 2020
LukasHirt
force-pushed
the
fix-dispatch-on-choose-account
branch
from
62dd552 to
d24f5f5
Compare
LukasHirt
commented
Nov 12, 2020
| @@ -88,10 +88,9 @@ generate: assets | |||
|
|
|||
| # TODO find a docker container with go and yarn so we can properly build assets in ci | |||
| #assets: assets/identifier/static assets/identifier/index.html | |||
| assets: assets/identifier/static | |||
| assets: static-assets | |||
There was a problem hiding this comment.
This needs to be run always, not only if it doesn't exist. When running yarn build it builds a placeholder logo for dev env. We are overwriting it with this with oC logo.
kulmann
reviewed
Nov 12, 2020
| @@ -33,7 +33,7 @@ const styles = theme => ({ | |||
| }); | |||
|
|
|||
| function Chooseaccount(props) { | |||
There was a problem hiding this comment.
It just saves one line, but we could have the signature like this:
function Chooseaccount({ loading, errors, classes, hello, history, dispatch }) {
LukasHirt
force-pushed
the
fix-dispatch-on-choose-account
branch
from
d24f5f5 to
b9d416b
Compare
kulmann
approved these changes
Nov 13, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix choose account dialogue.