-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Added tests to lists shared by me after sharee is deleted #8450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
13 tasks
SagarGi
force-pushed
the
SharedByMe/deleted_sharee
branch
from
February 15, 2024 04:54
a5f88b7
to
5841a8c
Compare
SagarGi
requested review from
saw-jan,
grgprarup,
amrita-shrestha,
PrajwolAmatya,
ScharfViktor,
nirajacharya2 and
nabim777
February 15, 2024 04:55
amrita-shrestha
approved these changes
Feb 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
saw-jan
requested changes
Feb 15, 2024
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
SagarGi
force-pushed
the
SharedByMe/deleted_sharee
branch
from
February 16, 2024 04:21
46eec57
to
f61ce57
Compare
Quality Gate passedIssues Measures |
saw-jan
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
ownclouders
pushed a commit
that referenced
this pull request
Feb 16, 2024
…s deleted (#8450) * Added tests to lists shared by me after sharee is deleted Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com> * Refactor tests * Review address Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com> * Review address Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com> --------- Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds test coverage for
sharedByMe
after sharee gets deleted with clearing up the user cache and the group cache for the deleted sharee and the group respectively.Related Issue:
#8111