Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Added tests to lists shared by me after sharee is deleted #8450

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Feb 14, 2024

Description

This PR adds test coverage for sharedByMe after sharee gets deleted with clearing up the user cache and the group cache for the deleted sharee and the group respectively.

Scenario: user lists shared resources for deleted sharee
Scenario: user lists shared resources for deleted group

Related Issue:

#8111

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
@SagarGi SagarGi force-pushed the SharedByMe/deleted_sharee branch from a5f88b7 to 5841a8c Compare February 15, 2024 04:54
@SagarGi SagarGi marked this pull request as ready for review February 15, 2024 04:55
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
@SagarGi SagarGi force-pushed the SharedByMe/deleted_sharee branch from 46eec57 to f61ce57 Compare February 16, 2024 04:21
@SagarGi SagarGi requested a review from saw-jan February 16, 2024 04:22
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SagarGi SagarGi merged commit c3d8954 into master Feb 16, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the SharedByMe/deleted_sharee branch February 16, 2024 09:31
ownclouders pushed a commit that referenced this pull request Feb 16, 2024
…s deleted (#8450)

* Added tests to lists shared by me after sharee is deleted

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

* Refactor tests

* Review address

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

* Review address

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

---------

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants