Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] adding test for updating expiration date of a share #8311

Merged
merged 1 commit into from
Feb 2, 2024
Merged

[tests-only] adding test for updating expiration date of a share #8311

merged 1 commit into from
Feb 2, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Jan 30, 2024 •
edited
Loading

Description

Scenarios added :

Scenario: user updates expiration date of a share

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Jan 30, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Jan 30, 2024
Closed
13 tasks
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-date branch 8 times, most recently from bd25fea to 4fc53da Compare February 1, 2024 09:32
@nirajacharya2 nirajacharya2 changed the title [tests-only][full-ci] adding test for updating expiration date of a share [tests-only] adding test for updating expiration date of a share Feb 1, 2024
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-date branch 4 times, most recently from 2768c77 to 8c003eb Compare February 1, 2024 11:00
@nirajacharya2 nirajacharya2 marked this pull request as ready for review February 1, 2024 11:25
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-date branch 3 times, most recently from 00fdc4f to ddff287 Compare February 2, 2024 03:59
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-date branch 2 times, most recently from fba3c91 to afd43a1 Compare February 2, 2024 08:38
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-date branch from afd43a1 to ed05e54 Compare February 2, 2024 11:22
@SagarGi @nirajacharya2
Added test for sharingNg for endpoint sharedByMe
755830a 
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

Added tests for list shared by me

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

adding test for updating permission of a share
@nirajacharya2 nirajacharya2 force-pushed the test-share-by-me-update-date branch from ed05e54 to 755830a Compare February 2, 2024 11:30
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

saw-jan
saw-jan approved these changes Feb 2, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan merged commit 4bea435 into master Feb 2, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the test-share-by-me-update-date branch February 2, 2024 12:05
ownclouders pushed a commit that referenced this pull request Feb 2, 2024
@nirajacharya2 @SagarGi
Added test for sharingNg for endpoint sharedByMe (#8311)
dad15ef 
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

Added tests for list shared by me

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

adding test for updating permission of a share

Co-authored-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@grgprarup grgprarup Awaiting requested review from grgprarup

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nirajacharya2 @grgprarup @saw-jan @SagarGi