Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only] Added test for sharingNg for endpoint sharedByMe from personal space #8285

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Jan 25, 2024

Description

This PR adds tests for listing shared by me resource shared from personal space for sharingNG.
Added scenarios:

Scenario: user lists the file shared from personal space
Scenario: user lists the folder shared from personal space
Scenario: user lists resources shared from personal space
Scenario: user lists the shared file inside of a folder from personal space

Related Issue:

#8111

Copy link

update-docs bot commented Jan 25, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@SagarGi SagarGi changed the title Added test for sharingNg for endpoint sharedByMe Added test for sharingNg for endpoint sharedByMe from personal space Jan 29, 2024
@SagarGi SagarGi self-assigned this Jan 29, 2024
@SagarGi SagarGi force-pushed the SharingNg/test/share_by_me branch from 9b2226a to 57c405b Compare January 29, 2024 06:39
@SagarGi SagarGi marked this pull request as ready for review January 29, 2024 06:42
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you check also parent reference added in this PR #8293 ?

tests/acceptance/features/apiSharingNg/sharedByMe.feature Outdated Show resolved Hide resolved
@SagarGi SagarGi requested a review from PrajwolAmatya January 29, 2024 11:11
@nirajacharya2 nirajacharya2 changed the title Added test for sharingNg for endpoint sharedByMe from personal space [tests-only][full-ci] Added test for sharingNg for endpoint sharedByMe from personal space Jan 30, 2024
@SagarGi SagarGi force-pushed the SharingNg/test/share_by_me branch from 1bf84c9 to dc2b0f4 Compare January 31, 2024 06:02
@SagarGi SagarGi force-pushed the SharingNg/test/share_by_me branch from dc2b0f4 to a092bb7 Compare January 31, 2024 06:09
@SagarGi SagarGi force-pushed the SharingNg/test/share_by_me branch 2 times, most recently from c4c26a6 to f007f53 Compare January 31, 2024 08:24
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should always be a schema

tests/acceptance/features/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
tests/acceptance/features/bootstrap/GraphContext.php Outdated Show resolved Hide resolved
@SagarGi SagarGi requested a review from saw-jan February 1, 2024 03:39
@SagarGi SagarGi force-pushed the SharingNg/test/share_by_me branch from c8193a4 to 41717cc Compare February 1, 2024 04:12
@SagarGi SagarGi changed the title [tests-only][full-ci] Added test for sharingNg for endpoint sharedByMe from personal space [tests-only] Added test for sharingNg for endpoint sharedByMe from personal space Feb 1, 2024
Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
@SagarGi SagarGi force-pushed the SharingNg/test/share_by_me branch from 41717cc to 29ecea2 Compare February 1, 2024 07:08
Copy link

sonarqubecloud bot commented Feb 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 1281a73 into master Feb 1, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the SharingNg/test/share_by_me branch February 1, 2024 08:09
ownclouders pushed a commit that referenced this pull request Feb 1, 2024
…ersonal space (#8285)

* Added tests to list shared by me resources

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>

* Review address

---------

Signed-off-by: sagargurung1001@gmail.com <sagargurung1001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants