graph/sharing: Add check for role conditions #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Keep this is draft as we need to bump reva for getting the other part of the fix: cs3org/reva#4462 Also, I am still trying to address the FIXME part about sharing space root (which requires the Owner condition) |
rhafer
force-pushed
the
issue/8131
branch
2 times, most recently
from
920c6f6 to
da31038
Compare
Closed
rhafer
force-pushed
the
issue/8131
branch
2 times, most recently
from
3bc99ad to
26e7dc6
Compare
9 tasks
Co-Owner and Manager are space specific roles. They need the UnifiedRoleConditionOwner.
Use the condition from the unifiedrole to check if the requested role is actually applicable to the selected resource. Fixes: owncloud#8131
Don't try to assign space specific roles to file or directory shares in positive tests. The API now forbids those correctly. We might want to add negative tests for that.
When computing the allowed roles for a spaceroot use the correct conditions.
Spaceroots require '@Subject.objectId Any_of @Resource.owners'.
Note: Updating or deleting the permissions on a spaceroot via
'v1beta1/drives/{driveid}/items/{itemid}/permissions/{permissionid}' does still
not work.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the condition from the unifiedrole to check if the requested role is actually applicable to the selected resource.