Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] Added API test coverage for checking file versions after multiple restores #8188

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[tests-only] Added API test coverage for checking file versions after multiple restores #8188

merged 1 commit into from
Jan 24, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jan 12, 2024

Description

Added API test coverage for checking file versions after multiple restores.

NOTE: file MUST be uploaded with empty content first

Steps to reproduce bug (webUI):

  1. create a new file with some content
  2. check the version with 0 byte
  3. restore the 0 byte version - OK
  4. restore the bytes versions - OK
  5. content is empty - BAD
  6. there is no versions - BAD

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@saw-jan saw-jan self-assigned this Jan 12, 2024
@saw-jan saw-jan requested a review from ScharfViktor January 12, 2024 06:59
@Salipa-Gurung

This comment was marked as outdated.

Sign in to view
@saw-jan saw-jan force-pushed the tests/test-coverage-enterprise-6249 branch from 094b933 to a696f19 Compare January 22, 2024 10:50
@saw-jan saw-jan marked this pull request as ready for review January 22, 2024 10:50
@saw-jan saw-jan force-pushed the tests/test-coverage-enterprise-6249 branch from a696f19 to c4ed6a6 Compare January 22, 2024 10:52
@saw-jan saw-jan force-pushed the tests/test-coverage-enterprise-6249 branch from c4ed6a6 to f0126e1 Compare January 24, 2024 06:02
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

SagarGi
SagarGi approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan saw-jan merged commit c8818f5 into master Jan 24, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/test-coverage-enterprise-6249 branch January 24, 2024 11:24
ownclouders pushed a commit that referenced this pull request Jan 24, 2024
@saw-jan
add test coverage for checking file versions after multiple restores (#…
551faee 
…8188)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SagarGi SagarGi SagarGi approved these changes

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@grgprarup grgprarup Awaiting requested review from grgprarup

@Salipa-Gurung Salipa-Gurung Awaiting requested review from Salipa-Gurung

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

Assignees

@saw-jan saw-jan

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saw-jan @Salipa-Gurung @SagarGi