Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Added test for sending share invitation to group with role #8009

Merged
merged 1 commit into from
Dec 21, 2023
Merged

[full-ci] [tests-only] Added test for sending share invitation to group with role #8009

merged 1 commit into from
Dec 21, 2023

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Dec 19, 2023 •
edited
Loading

Description

This PR adds a test for the new sharing graph API.

Added test scenarios:

- Scenario Outline: send share invitation to group with different roles

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup self-assigned this Dec 19, 2023
@grgprarup grgprarup mentioned this pull request Dec 19, 2023
Closed
36 tasks
@grgprarup grgprarup force-pushed the add-test-for-invite-group-sharingNg branch 2 times, most recently from 41b554e to ddc8979 Compare December 20, 2023 05:05
@grgprarup grgprarup marked this pull request as ready for review December 20, 2023 05:05
@grgprarup grgprarup force-pushed the add-test-for-invite-group-sharingNg branch from ddc8979 to 3ce27ba Compare December 20, 2023 06:12
PrajwolAmatya
PrajwolAmatya reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saw-jan saw-jan requested a review from ScharfViktor December 20, 2023 10:01
@grgprarup grgprarup force-pushed the add-test-for-invite-group-sharingNg branch from 3ce27ba to 07fd94f Compare December 21, 2023 03:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit 1b0e499 into master Dec 21, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-test-for-invite-group-sharingNg branch December 21, 2023 04:53
ownclouders pushed a commit that referenced this pull request Dec 21, 2023
@grgprarup
Added test for sending share invitation to group with role (#8009)
ba7f13c
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
@grgprarup @2403905
Added test for sending share invitation to group with role (owncloud#…
0b3384f 
…8009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PrajwolAmatya PrajwolAmatya PrajwolAmatya left review comments

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@SwikritiT SwikritiT Awaiting requested review from SwikritiT

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@grgprarup @saw-jan @PrajwolAmatya @ScharfViktor