Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[full-ci] [tests-only] Added test for sending share invitation to user with role #7984

Merged
merged 1 commit into from
Dec 19, 2023
Merged

[full-ci] [tests-only] Added test for sending share invitation to user with role #7984

merged 1 commit into from
Dec 19, 2023

Conversation

grgprarup
Copy link
Contributor

@grgprarup grgprarup commented Dec 15, 2023 •
edited
Loading

Description

This PR adds a test for the new sharing graph API.

Added test scenarios:

- Scenario Outline: send sharing invitation to user with different roles via the Graph API

Related Issue

How Has This Been Tested?

  • Locally
  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch from 84b6bd5 to 20f959b Compare December 18, 2023 07:24
@grgprarup grgprarup self-assigned this Dec 18, 2023
@grgprarup grgprarup mentioned this pull request Dec 18, 2023
Closed
36 tasks
@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch from 20f959b to 1728c90 Compare December 18, 2023 07:30
@grgprarup grgprarup marked this pull request as ready for review December 18, 2023 08:23
@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch from 1728c90 to 393c6e4 Compare December 18, 2023 08:26
@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch from 393c6e4 to 1904e1b Compare December 18, 2023 09:05
@grgprarup grgprarup marked this pull request as draft December 18, 2023 11:17
@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch from 1904e1b to 4e85f76 Compare December 19, 2023 04:27
@grgprarup grgprarup requested a review from saw-jan December 19, 2023 04:28
@grgprarup grgprarup marked this pull request as ready for review December 19, 2023 04:28
SwikritiT
SwikritiT reviewed Dec 19, 2023
View reviewed changes
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other than that LGTM

@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch from 4e85f76 to e0f41ad Compare December 19, 2023 06:52
@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch from e0f41ad to 3ed8da3 Compare December 19, 2023 07:20
@grgprarup grgprarup requested a review from saw-jan December 19, 2023 07:20
@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch from 3ed8da3 to 8c3d0da Compare December 19, 2023 07:21
@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch 2 times, most recently from 9e05b8d to 51a322b Compare December 19, 2023 10:37
ScharfViktor
ScharfViktor approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we still need create invite using permittions. but we can implement it in the next PR
thank you 👍

@grgprarup grgprarup force-pushed the add-test-for-invite-user-sharingNg branch from 51a322b to 87d3762 Compare December 19, 2023 11:12
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

SagarGi
SagarGi approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@grgprarup grgprarup merged commit 325eeb1 into master Dec 19, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-test-for-invite-user-sharingNg branch December 19, 2023 12:39
ownclouders pushed a commit that referenced this pull request Dec 19, 2023
@grgprarup
Merge pull request #7984 from owncloud/add-test-for-invite-user-shari…
31b92d5 
…ngNg

[full-ci] [tests-only] Added test for sending share invitation to user with role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SwikritiT SwikritiT SwikritiT left review comments

@SagarGi SagarGi SagarGi approved these changes

@saw-jan saw-jan saw-jan approved these changes

@ScharfViktor ScharfViktor ScharfViktor approved these changes

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nirajacharya2 nirajacharya2 Awaiting requested review from nirajacharya2

Assignees

@grgprarup grgprarup

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grgprarup @SwikritiT @SagarGi @saw-jan @ScharfViktor