Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] tests: update tests related to deletion of public link password to use ocsv2 as well #7875

Conversation

SwikritiT
Copy link
Contributor

@SwikritiT SwikritiT commented Dec 4, 2023

Part of: #7823
Updates the scenarios added in #7540 to use ocs-v2 as well

@SwikritiT SwikritiT self-assigned this Dec 4, 2023
@SwikritiT SwikritiT marked this pull request as ready for review December 4, 2023 11:06
Comment on lines +374 to +377
| 1 | change | 200 |
| 2 | change | 400 |
| 1 | create | 200 |
| 2 | create | 400 |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Http status code are a little bit different depending on the ocs version idk if this is expected or not

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, we have these differences between v1 and v2 in oc10 as well

@SwikritiT SwikritiT force-pushed the tests/update-delete-link-password-to-include-both-ocs-versions branch from 1e7f74a to 6beaa0d Compare December 5, 2023 03:39
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SwikritiT SwikritiT force-pushed the tests/update-delete-link-password-to-include-both-ocs-versions branch from 72f88f1 to cd65efd Compare December 7, 2023 05:11
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SwikritiT SwikritiT merged commit 30f16dd into master Dec 7, 2023
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/update-delete-link-password-to-include-both-ocs-versions branch December 7, 2023 06:26
ownclouders pushed a commit that referenced this pull request Dec 7, 2023
…ic link password to use ocsv2 as well (#7875)

* tests: update tests related to deletion of public link password to use ocsv2 as well

* tests: update expected to fail file
2403905 pushed a commit to 2403905/ocis that referenced this pull request Dec 8, 2023
…ic link password to use ocsv2 as well (owncloud#7875)

* tests: update tests related to deletion of public link password to use ocsv2 as well

* tests: update expected to fail file
2403905 pushed a commit to 2403905/ocis that referenced this pull request Jan 24, 2024
…ic link password to use ocsv2 as well (owncloud#7875)

* tests: update tests related to deletion of public link password to use ocsv2 as well

* tests: update expected to fail file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants