Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ocis 7768 geogebra thumbnails #7804

Merged

Conversation

dragonchaser
Copy link
Contributor

@dragonchaser dragonchaser commented Nov 24, 2023

This PR adds support for geogebra preview

refs #7768

Copy link

update-docs bot commented Nov 24, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@dragonchaser dragonchaser force-pushed the ocis-7768-geogebra-thumbnails branch from 6ab077f to 288d34b Compare November 27, 2023 12:21
Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Ralf Haferkamp <rhafer@owncloud.com>

Signed-off-by: Christian Richter <crichter@owncloud.com>
Co-authored-by: Florian Schade <fschade@owncloud.com>

Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser dragonchaser force-pushed the ocis-7768-geogebra-thumbnails branch from 9e34d1e to f3ed5ad Compare November 27, 2023 15:26
Signed-off-by: Christian Richter <crichter@owncloud.com>
@dragonchaser dragonchaser marked this pull request as ready for review November 27, 2023 19:49
Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks...

Signed-off-by: Christian Richter <crichter@owncloud.com>
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

70.0% 70.0% Coverage
0.4% 0.4% Duplication

@dragonchaser dragonchaser merged commit 2811a01 into owncloud:master Nov 28, 2023
@dragonchaser dragonchaser deleted the ocis-7768-geogebra-thumbnails branch November 28, 2023 09:46
ownclouders pushed a commit that referenced this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants