Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test-only] [full-ci] Backport lock tests #7628

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

S-Panta
Copy link
Contributor

@S-Panta S-Panta commented Oct 31, 2023

This PR backports #7595

@update-docs
Copy link

update-docs bot commented Oct 31, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

* add new lock tests

* fix after review

* Update WebDavLockingContext.php
@S-Panta S-Panta force-pushed the backport/createLockFileTest branch from 4577e85 to bc70f2a Compare October 31, 2023 11:50
Copy link

sonarqubecloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@S-Panta S-Panta marked this pull request as ready for review November 1, 2023 06:46
@saw-jan saw-jan changed the title [test-only] [full-ci] new lock tests [test-only] [full-ci] Backport lock tests Nov 1, 2023
@S-Panta S-Panta self-assigned this Nov 1, 2023
@S-Panta S-Panta added the QA:team label Nov 1, 2023
@phil-davis phil-davis merged commit 09809a2 into stable-4.0 Nov 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport/createLockFileTest branch November 1, 2023 06:55
ownclouders pushed a commit that referenced this pull request Nov 1, 2023
[test-only] [full-ci] Backport lock tests
Comment on lines +146 to +149
### [500 error if viewer tries to lock file](https://github.com/owncloud/ocis/issues/7600)

- [apiSpaces/lockFiles.feature:144](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/lockFiles.feature#L144)
- [apiSpaces/lockFiles.feature:207](https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSpaces/lockFiles.feature#L207)
Copy link
Contributor

@SwikritiT SwikritiT Nov 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue has already been closed #7600 so might not be the correct issue to tag tests on
cc @saw-jan maybe it's same in master someone needs to change the issue

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport of another PR is needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants