Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix group id claim #7352

Merged
merged 1 commit into from
Sep 26, 2023
Merged

fix group id claim #7352

merged 1 commit into from
Sep 26, 2023

Conversation

butonic
Copy link
Member

@butonic butonic commented Sep 25, 2023

reva never uses groupid. actually only the ldap group manager knows about group_id. the fixme makes a little funny.

@update-docs
Copy link

update-docs bot commented Sep 25, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@butonic butonic requested a review from rhafer September 25, 2023 19:55
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@rhafer rhafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Do you have plans to used the cs3 backend anywhere though? Please note that it's pretty much incomplete (I guess you noted already) and nowhere near productions readiness.

@butonic butonic merged commit c083f59 into master Sep 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-group-id-claim branch September 26, 2023 13:13
ownclouders pushed a commit that referenced this pull request Sep 26, 2023
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
ownclouders pushed a commit that referenced this pull request Sep 27, 2023
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants