Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Chase the pipline ghost #7309

Merged
merged 2 commits into from
Sep 22, 2023

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Sep 19, 2023

Running pipelines to find the issue for #7279

First try: Let services exit hard when they fail. This should clean up logs so the underlying issue is more visible

Second try: Use ociswrapper to restart ocis when it exits

@update-docs
Copy link

update-docs bot commented Sep 19, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kobergj kobergj force-pushed the ChaseThePipelineGhost branch from 6587e59 to 1220e1b Compare September 19, 2023 12:37
@kobergj kobergj changed the title Chase the pipline ghost Chase the pipeline ghost Sep 19, 2023
@kobergj kobergj changed the title Chase the pipeline ghost [full-ci] Chase the pipline ghost Sep 19, 2023
@kobergj kobergj force-pushed the ChaseThePipelineGhost branch 3 times, most recently from e4b455d to 841adba Compare September 21, 2023 09:29
@kobergj kobergj marked this pull request as ready for review September 21, 2023 10:36
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
@kobergj kobergj force-pushed the ChaseThePipelineGhost branch from 841adba to e9d5b23 Compare September 21, 2023 11:53
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
77.1% 77.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the behavior of ocis to fail early. We should document this as now ocis might die when a race condition causes startup to fail. This is not a problem when using a service orchestrator as they will deal with restarting ocis.

We need to deal with services starting out of order and still reconnecting to each other. But that is another topic. For now, I'm happy to make CI more stable by using the wrapper (that automatically restarts ocis)

@kobergj
Copy link
Collaborator Author

kobergj commented Sep 22, 2023

Yes I 100% agree. I'll merge as is for now

@kobergj kobergj merged commit 8bf3f2f into owncloud:master Sep 22, 2023
@kobergj kobergj deleted the ChaseThePipelineGhost branch September 22, 2023 09:03
ownclouders pushed a commit that referenced this pull request Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants