-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[full-ci] Chase the pipline ghost #7309
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
6587e59
to
1220e1b
Compare
e4b455d
to
841adba
Compare
Signed-off-by: jkoberg <jkoberg@owncloud.com>
Signed-off-by: jkoberg <jkoberg@owncloud.com>
841adba
to
e9d5b23
Compare
SonarCloud Quality Gate failed.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This changes the behavior of ocis to fail early. We should document this as now ocis might die when a race condition causes startup to fail. This is not a problem when using a service orchestrator as they will deal with restarting ocis.
We need to deal with services starting out of order and still reconnecting to each other. But that is another topic. For now, I'm happy to make CI more stable by using the wrapper (that automatically restarts ocis)
Yes I 100% agree. I'll merge as is for now |
[full-ci] Chase the pipline ghost
Running pipelines to find the issue for #7279
First try: Let services exit hard when they fail. This should clean up logs so the underlying issue is more visible
Second try: Use ociswrapper to restart ocis when it exits