Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix problems with unescaping values. #6073

Merged
merged 2 commits into from
Apr 20, 2023
Merged

Try to fix problems with unescaping values. #6073

merged 2 commits into from
Apr 20, 2023

Conversation

Excds
Copy link

@Excds Excds commented Apr 18, 2023 •
edited
Loading

Overwriting URL.RawPath with EscapedPath to avoid problems with unescaping values.

Fixes #5083

@Excds Excds self-assigned this Apr 18, 2023
@update-docs
Copy link

update-docs bot commented Apr 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Apr 18, 2023 •
edited
Loading

💥 Acceptance test localApiTests-apiSpacesShares-ocis failed. Further test are cancelled...

@rhafer
Copy link
Contributor

rhafer commented Apr 19, 2023

This is looking good:

runsh: There were no unexpected failures.
runsh: Total unexpected passed scenarios throughout the test run:
apiGraph/deleteGroup.feature:49
apiGraph/deleteGroup.feature:50
apiGraph/deleteGroup.feature:51
apiGraph/editGroup.feature:25

@Excds Seems we can remove some items from the expected failures list ;-)

@Excds Excds changed the title [Draft] Try to fix problems with unescaping values. Try to fix problems with unescaping values. Apr 19, 2023
@Excds Excds added the Status:Needs-Review Needs review from a maintainer label Apr 19, 2023
@Excds Excds requested a review from rhafer April 19, 2023 08:06
rhafer
rhafer suggested changes Apr 19, 2023
View reviewed changes
services/graph/pkg/service/v0/graph.go Outdated
@@ -76,6 +76,9 @@ type Graph struct {

// ServeHTTP implements the Service interface.
func (g Graph) ServeHTTP(w http.ResponseWriter, r *http.Request) {
// Adding this as a fix for some weird unescaping issues we've had.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add some more info here what the issue actually is. (With a link to the chi-router github issue?)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: I think this fixes some open issue(s), could you please mention them with Fixes: <#issue> in the commit message?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, should have done that. Fixed now.

@Excds Excds force-pushed the excds/bugfix/fix_unescaping_problems_v2 branch from e8669f4 to 1d7980a Compare April 19, 2023 10:27
@Excds Excds force-pushed the excds/bugfix/fix_unescaping_problems_v2 branch from 1d7980a to 548ed65 Compare April 20, 2023 07:33
@Excds Excds force-pushed the excds/bugfix/fix_unescaping_problems_v2 branch from 548ed65 to 0d6500a Compare April 20, 2023 08:33
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Excds Excds merged commit ce9af44 into master Apr 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the excds/bugfix/fix_unescaping_problems_v2 branch April 20, 2023 12:02
ownclouders pushed a commit that referenced this pull request Apr 20, 2023
Merge pull request #6073 from owncloud/excds/bugfix/fix_unescaping_pr…
2037057 
…oblems_v2

Try to fix problems with unescaping values.
ownclouders pushed a commit that referenced this pull request Apr 20, 2023
Merge pull request #6073 from owncloud/excds/bugfix/fix_unescaping_pr…
7b8f36b 
…oblems_v2

Try to fix problems with unescaping values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhafer rhafer rhafer approved these changes

Assignees

@Excds Excds

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Group having percentage (%) can be created but cannot be GET
3 participants
@Excds @ownclouders @rhafer