Remove dead and unused IDM envvar #6055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
|
Kudos, SonarCloud Quality Gate passed!
|
kobergj
approved these changes
Apr 14, 2023
ownclouders
pushed a commit
that referenced
this pull request
Apr 14, 2023
Remove dead and unused IDM envvar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on admin docs, I identified two IDM envvars that can safely be removed:
ACCOUNTS_DEMO_USERS_AND_GROUPSThis envvar was stated in [full-ci] set demo users to default off #3474 to be removed after switching to LibreIDM. I have checked the whole ocis repo for occurences of this envvar and it is only present in the IDM service as leftover.
OCIS_ACCOUNTS_DEMO_USERS_AND_GROUPSThis one was "accidentially" added but there is no global use of one of the underlaying envvar.
@micbar adding you as you have written the referenced PR.