Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci]Json assertion apigraph master branch #5989

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

SagarGi
Copy link
Member

@SagarGi SagarGi commented Apr 3, 2023

Description

This PR is the forward port of the json-assertion in suite apiGraph #5798. It also adds the missing schema assertion for the new steps in the master branch in apiGraph suite. And also updates the expexted to failure line numbers.

Related Issue:

#3179

@SagarGi SagarGi self-assigned this Apr 3, 2023
@SagarGi SagarGi added the QA:team label Apr 3, 2023
@SagarGi SagarGi force-pushed the json_assertion_apigraph branch from b705adf to dbb956d Compare April 3, 2023 04:05
@SagarGi SagarGi marked this pull request as ready for review April 3, 2023 04:05
@SagarGi SagarGi force-pushed the json_assertion_apigraph branch 2 times, most recently from 6e0562e to 29f78a5 Compare April 4, 2023 04:22
@ownclouders
Copy link
Contributor

ownclouders commented Apr 4, 2023

@SagarGi SagarGi force-pushed the json_assertion_apigraph branch from 29f78a5 to be2af59 Compare April 4, 2023 05:21
@SagarGi SagarGi force-pushed the json_assertion_apigraph branch from be2af59 to 6db5a9e Compare April 4, 2023 10:57
@SagarGi SagarGi requested a review from ScharfViktor April 4, 2023 10:58
@SagarGi SagarGi requested a review from individual-it April 5, 2023 03:26
Copy link
Contributor

@SwikritiT SwikritiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SagarGi SagarGi force-pushed the json_assertion_apigraph branch from 6db5a9e to f21b648 Compare April 5, 2023 04:05
@SagarGi SagarGi force-pushed the json_assertion_apigraph branch from f21b648 to be5ceab Compare April 5, 2023 06:03
@SagarGi SagarGi requested a review from saw-jan April 5, 2023 06:04
@SagarGi SagarGi force-pushed the json_assertion_apigraph branch from be5ceab to f103173 Compare April 5, 2023 06:23
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SagarGi SagarGi merged commit b52597d into master Apr 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the json_assertion_apigraph branch April 5, 2023 08:20
ownclouders pushed a commit that referenced this pull request Apr 5, 2023
* Json assertion for api graph suite

* Review Address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants