-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci]Json assertion apigraph master
branch
#5989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b705adf
to
dbb956d
Compare
6e0562e
to
29f78a5
Compare
E2E tests failed: https://drone.owncloud.com/owncloud/ocis/21134/88/1 💥 To see the trace, please open the link in the console ...
npx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/21134/tracing/folder-alice-2023-4-5-04-21-25.zipnpx playwright show-trace https://cache.owncloud.com/public/owncloud/ocis/21134/tracing/folder-brian-2023-4-5-04-21-40.zip |
29f78a5
to
be2af59
Compare
ScharfViktor
reviewed
Apr 4, 2023
be2af59
to
6db5a9e
Compare
ScharfViktor
approved these changes
Apr 4, 2023
SwikritiT
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
saw-jan
reviewed
Apr 5, 2023
saw-jan
reviewed
Apr 5, 2023
saw-jan
reviewed
Apr 5, 2023
6db5a9e
to
f21b648
Compare
saw-jan
reviewed
Apr 5, 2023
f21b648
to
be5ceab
Compare
be5ceab
to
f103173
Compare
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is the forward port of the
json-assertion
in suiteapiGraph
#5798. It also adds the missing schema assertion for the new steps in the master branch inapiGraph
suite. And also updates the expexted to failure line numbers.Related Issue:
#3179